grass.pydispatch: Apply code changes from upstream pydispatcher repo #4033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual combination of latest changes of repo https://github.com/mcfletch/pydispatcher
|
This isn't exactly a style-only PR. Its more a normal PR. |
echoix
changed the title
wenzeslaus
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
This looks safe as it is not touching any code which would be directly used by our code or where our code would rely on some implementation details.
This is (only) used in GUI though, so the only ultimate test when we try couple things there, e.g., the Data panel.
BTW, the custom signal API is really the reason why we included pydispatch, so all usages of pydispatch elsewhere in the code should be through the signal API. |
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
…SGeo#4033) python(pydispatch): Apply code changes from upstream pydispatcher repo Manual combination of latest changes of repo https://github.com/mcfletch/pydispatcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual combination of latest changes of repo https://github.com/mcfletch/pydispatcher
Once black is applied, the actual diff isn't really big. Their repo layout seemed to have changed a big, but I went and copied the (relevant-only) files one by one. It isn't a very active project, but still.
This is the best approach I could think of that would make our vendored dependency get updated, considering they don't really have (newer) releases, and we have some more files that extend the original code like https://github.com/OSGeo/grass/blob/ff453d215a3244644ef207f2d5d065f680016da0/python/grass/pydispatch/signal.py