style: fix numpy-deprecation-rules (NPY) #4062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GUI
echoix
reviewed
Jul 15, 2024
|
Shouldn't if we use numpy officially in pygrass, shouldn't we have it listed in our dependencies (as we have it transitively from matplotlib). |
|
And you beat me to it, I was just starting a similar fix only on my phone and CI... |
I would agree. |
echoix
previously approved these changes
Jul 15, 2024
|
Where did you see the last two failures that you fixed in the subsequent commits? I didn't find them |
Here: https://github.com/OSGeo/grass/actions/runs/9947526949/job/27480342764 |
echoix
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the last remaning issues with numpy-deprecation-rules in ruff, that had been excluded until now.
The changes should ensure compatibility with NumPy 2.0 (see #4058).