-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checks: Flake8 F841 fixes in the wxpython directory part 1 #4244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the .flake8 misses changes in wxpython/animation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I was not sure about keeping reference to wx.App around, but I don't see any specific instructions in the doc. Plus now I see that it is a test. Let me know if you want more feedback from me here for some reason.
The initialization of wx.App is required by all wxPython applications, unless I misunderstood. My apologies for not understanding what you meant by "Plus now I see it's a test"? |
Description
Flake8 F841 (local variable assigned to but never used) fixes in the
gui/wxpython/animation
andgui/wxpython/core
directory.Motivation and context
Changes require resolving a part of Flake8 warnings that are currently ignored. The issue title and number as follows.
How has this been tested?
animation:
Bify tested entering multiple raster datasets and it worked.
core:
Not tested.
Types of changes
Two declarations of unused functions were deleted.
functionality to not work as before)
Checklist
pre-defined prefixes
of this project.