Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Use any or all instead of for loop (SIM110) #4404

Merged
merged 3 commits into from
Sep 29, 2024
Merged

style: Use any or all instead of for loop (SIM110) #4404

merged 3 commits into from
Sep 29, 2024

Conversation

echoix
Copy link
Member

@echoix echoix commented Sep 28, 2024

Fixes Ruff rule reimplemented-builtin (SIM110): https://docs.astral.sh/ruff/rules/reimplemented-builtin/

@echoix echoix added this to the 8.5.0 milestone Sep 28, 2024
@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python libraries module docs general labels Sep 28, 2024
ninsbl
ninsbl requested changes Sep 28, 2024
View reviewed changes
Copy link
Member

@ninsbl ninsbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two cases that look like a in check, which seems simpler. The rest looks good.

gui/wxpython/psmap/instructions.py Show resolved Hide resolved
scripts/g.search.modules/g.search.modules.py Outdated Show resolved Hide resolved
@echoix @ninsbl
Update g.search.modules.py
8d2b1f8 
Co-authored-by: Stefan Blumentrath <stefan.blumentrath@gmx.de>
@echoix echoix requested a review from ninsbl September 28, 2024 21:15
@echoix echoix merged commit e82663c into OSGeo:main Sep 29, 2024
26 checks passed
@echoix echoix deleted the fix-SIM110-reimplemented-builtin branch September 29, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninsbl ninsbl ninsbl approved these changes

Assignees
No one assigned
Labels
docs general GUI wxGUI related libraries module Python Related code is in Python
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@echoix @ninsbl