wxGUI: Fixed E722 in frame.py

[arohanajit]

Fixed E722 by specifying exceptions

• AttributeError incase object does not have .name or GetLayerInfo() attribute
• KeyError incase object does not have mapplayer attribute
• ValueError and IndexError for invalid dim types and indexing

[echoix]

Wait until we merge #4439 before updating this one, and at that time you could adjust the flake8 file for exclusions. If you do it before, the CI will be useless as there will be conflicts on that file.

[echoix]

Ok, finally #4439 ended up finishing and merging, so time to update this one and its flake8

[echoix]

Is it expected that no flake8 exclusions were removed from the config file here?

[arohanajit]

I noticed that a lot of merge conflicts were happening since different PRs were being merged with different modifications to .flake8. Since I'll be working with this file for a while, I thought I'd try removing these entries from .flake8 post merge once I move on to next set of errors. Please let me know if you'd rather this be the way it was before

[echoix]

What I usually do when having this kind of conflicts happening with ruff exclusions, is to do a PR, skip a few lines, do a PR for the other, skip a few lines, make a PR, and wait for others to be merged before filing them in. Sometimes I have them already made, but waiting in my fork before sending them.

Or I find a second front to work on in the meantime that doesn't touch the same files.

[petrasovaa]

Hm, looks like we missed TypeError:

Traceback (most recent call last):
  File "/home/akratoc/dev/grass/grass_main/dist.x86_64-pc-
linux-gnu/gui/wxpython/lmgr/layertree.py", line 1759, in
OnDeleteLayer

if self.GetLayerInfo(item, key="type") != "group":
  File "/home/akratoc/dev/grass/grass_main/dist.x86_64-pc-
linux-gnu/gui/wxpython/lmgr/layertree.py", line 337, in
GetLayerInfo

return self.GetPyData(layer)[0][key]

TypeError
:
'NoneType' object is not subscriptable

@arohanajit would you mind creating a PR that adds TypeError in cases GetLayerInfo is used in try/except blocks?

[arohanajit]

Yes, I'll push one PR with this change today