pj_transform: reset error state before each call to pj_inv/pj_fwd #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues raised in https://lists.osgeo.org/pipermail/gdal-dev/2018-April/048446.html The use case is that pj_transform() is called from geos projection to something else, with multiple coordinates. If one of the coordinate tuple fails the inverse transform of geos, it fails with PJD_ERR_TOLERANCE_CONDITION. Causing all following coordinates to fail since the error state is not reset.
|
Looks good to me |
|
@jef-n please note this bug also affects QGIS' OTF reprojection of XYZ layers (although it's not a problem as long as QGIS builds use PROJ 4.9.3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues raised in https://lists.osgeo.org/pipermail/gdal-dev/2018-April/048446.html
The use case is that pj_transform() is called from geos projection to something else,
with multiple coordinates. If one of the coordinate tuple fails the inverse
transform of geos, it fails with PJD_ERR_TOLERANCE_CONDITION. Causing all following
coordinates to fail since the error state is not reset.