-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kiwi sets GRUB_DISTRIBUTOR again #1416
Comments
I think it was added back because grub2-mkconfig uses it. many references available in /usr/sbin/grub2-mkconfig. So if this is obsolete why is there code in grub2-mkconfig handling it ? |
Can this really be safely removed or do we need to add yet another check for a grub2-mkconfig feature. All this is a mess across distributions really a pita |
grub2-mkconfig creates a proper string based on /etc/os-release if GRUB_DISTRIBUTOR is not set. That is just fine so a yast install does not set GRUB_DISTRIBUTOR. |
grub mkconfig creates a proper string based on /etc/os-release if GRUB_DISTRIBUTOR is not set. We assume this to be true for all distributions. This Fixes #1416
Problem description
kiwi sets GRUB_DISTRIBUTOR /etc/default/grub
Expected behaviour
kiwi not setting GRUB_DISTRIBUTOR, that behavior was disabled previously:
https://bugzilla.suse.com/show_bug.cgi?id=1032119&GoAheadAndLogIn=1
by commit
295a7fa
however 162d5c9 introduced it again
Steps to reproduce the behaviour
Build openSUSE:Leap:15.2:MicroOS/openSUSE-MicroOS, it produces a grub menu that says "openSUSE MicroOS" instead of "openSUSE MicroOS 15.2":
https://openqa.opensuse.org/tests/1247233#step/disk_boot/1
OS and Software information
The text was updated successfully, but these errors were encountered: