Shared memory #131
Merged
Shared memory #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ough children. In the non-const visitor, it's conceivable that a visitor might add or remove a child, and apparently at least MSVC uses iterators to implement range-based for loops. Running osvr_print_tree in a debug build triggered a "safe iterator" assert which I finally figured out was because of being able to modify the container we were iterating over.
We had a global imaging report, that was trying to delete the buffer after the rest of the system shut down.
|
@godbyk thanks for the code review. I had forgotten to try building here with gcc/mingw, and further with Linux - we really need to get a pull request builder set up properly. Remaining issues:
|
… create a better shared memory name.
…larify with comments when we're not initializing right away.
…, and turn off xsi shared memory for now.
Apparently it acts like MSVC: should have used functional tests rather than compiler identity tests all along.
|
OK, have addressed the issues that came up, and now have it building in my own tests on MSVC 2013, gcc mingw64, and debian jessie gcc. |
rpavlik
added a commit
that referenced
this pull request
May 27, 2015
Shared memory support, primarily/initially for imaging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial iteration with shared memory support for imaging. Enables larger images and multi-byte depth per channel, faster (because of using shared memory vs serializing into/out of network buffers).