Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared memory #131

Merged
merged 26 commits into from
May 27, 2015
Merged

Shared memory #131

merged 26 commits into from
May 27, 2015

Conversation

rpavlik
Copy link
Member

@rpavlik rpavlik commented May 26, 2015

This is an initial iteration with shared memory support for imaging. Enables larger images and multi-byte depth per channel, faster (because of using shared memory vs serializing into/out of network buffers).

…ough children.

In the non-const visitor, it's conceivable that a visitor might
add or remove a child, and apparently at least MSVC uses iterators
to implement range-based for loops. Running osvr_print_tree in a debug
build triggered a "safe iterator" assert which I finally figured out
was because of being able to modify the container we were iterating over.
We had a global imaging report, that was trying to delete the buffer
after the rest of the system shut down.
@rpavlik
Copy link
Member Author

rpavlik commented May 27, 2015

@godbyk thanks for the code review. I had forgotten to try building here with gcc/mingw, and further with Linux - we really need to get a pull request builder set up properly.

Remaining issues:

  • build error in Imaging.cpp example under mingw64 gcc
  • what to do with xsi_shared_memory
  • rename class and probably split up files - that .cpp file is much longer than I'd like.

@rpavlik
Copy link
Member Author

rpavlik commented May 27, 2015

OK, have addressed the issues that came up, and now have it building in my own tests on MSVC 2013, gcc mingw64, and debian jessie gcc.

rpavlik added a commit that referenced this pull request May 27, 2015
Shared memory support, primarily/initially for imaging.
@rpavlik rpavlik merged commit 3223ada into master May 27, 2015
@rpavlik rpavlik deleted the shared-memory branch May 28, 2015 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants