-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests: port all to Catch2 2.8.0, removing old gtest #602
Conversation
No longer need my hacked-together catch_typelist!
That last one is a bit more complicated, automated-transformation just makes a mess of it.
Apparently function differs between my cmake version and travis-ci's
They're all static_asserts anyway...
OK, I have now ported all the tests, so they should all build on MSVC2019 now too :) |
Try to fix GCC 4.8 on Travis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiles out of the box on Visual Studio 2019, even when OpenCV is not installed. Did not try installing Catch-22 to see if it also compiles in that case.
When I run the tests, all but #6 QuatExpMap succeed. It fails. Here is its output: $ ./QuatExpMap.exe
|
That's interesting that the round-trips are close but not quite. I was getting exact here on Linux. However, I see I already made the other direction of round trip "approximate" (wrapping one endpoint in ApproxVec), so I'll try that with the quat one too. (ApproxQuat, in this case - these two were added by me but function equivalently to the Catch2 Approx() feature with doubles - basically a safe floating-point compare.) |
Wasn't needed on Buster, but might be needed on VS2019.
I was able to relatively quickly update most tests to Catch2, leaving behind the old version of catch entirely. I have also now done the last remaining gtest test (QuatExpMap) which became simpler when moved to Catch2, meaning that google test is no longer needed either and has been removed.
Builds on Debian Buster, tests pass except for test_fwd_headers which I'm pretty sure I didn't touch.