Merge USB Serial Autodetect/Enumeration lib #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix return val on missing serial port. - Add vid/pid in osvr server config files for YEI devices. Remove hardcoded com port
|
So this needs a Linux port in order to pass CI. It should be pretty easy, since I think you can just use sysfs to do it (so it turns into a filesystem traversal), but that will block the merge. Would like to get this merged ideally shortly before 0.2, since changes to the manual configuration API will be coming in 0.2 which directly affects this code's usage. @yboger Is this a reasonable item to have @godbyk do? |
… reset commands for YEI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.