Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus and better explain 5.3.10 to resolve #1556 #2016

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

tghosth
Copy link
Collaborator

@tghosth tghosth commented Aug 12, 2024

This Pull Request relates to issue #1556

@tghosth tghosth enabled auto-merge (squash) August 12, 2024 14:44
@tghosth tghosth mentioned this pull request Aug 12, 2024
@tghosth tghosth requested a review from elarlang August 12, 2024 14:45
@jmanico
Copy link
Member

jmanico commented Aug 13, 2024

I would suggest dropping the sanitization part and just focus on the "good" defenses.

@tghosth
Copy link
Collaborator Author

tghosth commented Aug 14, 2024

I would suggest dropping the sanitization part and just focus on the "good" defenses.

Hmm interesting, @elarlang what do you think?

@elarlang
Copy link
Collaborator

I also think that sanitization part does not fit there. For that exact reason we have 5.2.2.

@tghosth
Copy link
Collaborator Author

tghosth commented Aug 14, 2024

Ok so what do you think now @jmanico @elarlang, I removed the sanitization bit.

@elarlang
Copy link
Collaborator

I'm ok to go with that.

In a way it is not now just modified, but split to 5.3.1. I'm not sure I have tag logic made for that situation...

@tghosth tghosth merged commit 4c1ee29 into v5m_refresh Aug 14, 2024
6 checks passed
@tghosth tghosth deleted the v5_refresh_1556 branch August 14, 2024 13:04
tghosth added a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants