Increased memory limit for crapi-identity container #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyushroshan
approved these changes
May 25, 2022
piyushroshan
added a commit
that referenced
this pull request
May 26, 2022
* Removed reference to Traceable from Service - Web * Removed reference to Traceable from Service - Workshop * build-docker-images build-docker-images on pull request * Removed Author meta tag * CI workflow setup * Fix tags syntax * Convert env to job.build.env * Convert job context to needs job output * Fix workflow push condition * Push condition workflow fix * Removed mentions of Traceable from the source code (#22) * Removed all Traceable mentions in crapi-community service * Removed all Traceable mentions in crapi-identity service * Removed all Traceable mentions in deploy configs and Removed Copyright file * Removed all Traceable mentions in README and LICENSE * Removed all Traceable mentions in k8 deploy configs * Correct indentation fixing workflow issues (#34) * Modified docker configs to support ARM builds (#20) * Added scripts to built mailhog * Moved from docker-compose-wait to pure docker-compose alternative * Removed GOOS and GOARCH env variables * Modified bash build script to only run bash files recursively Co-authored-by: Roshan Piyush <roshan.piyush@traceable.ai> * Batch Files To Deploy Docker on Windows Machine (#19) * Added batch files for all services * Added the batch file to build all docker images * Removed comments from build batch files * Updated README * Modified README * Removed Print Statements Co-authored-by: Roshan Piyush <roshan.piyush@traceable.ai> * Docker compose support variables for different release (#37) * Docker compose support variables for different release * Update build wrappers * Change pull_request docker login condition (#40) * Retrieval Of Orders Bug (#38) Retrieval Of Orders Bug (#38) * Added Heap memory limit for crapi-identity java application (#36) Co-authored-by: Roshan Piyush <roshan.piyush@traceable.ai> * Update readme (#43) * Update CI branch refs (#44) * Workflow merge fix (#45) * vagrant: upgrade to ubuntu jammy (#42) vagrant: upgrade to ubuntu jammy (#42) * chore: adds contributing guidelines, code of conduct, PR and issue templates (#46) Co-authored-by: Jayesh Bapu Ahire <jayeshbahire@gmail.coml> * Modify Templates: Pull Request and Issues (#48) * Update templates * Modify guidelines * Fix workflow path * Max File Size Limit for Video Files (#47) * Added Video Size Limit * Load built images in docker (#51) * Seperate build, run and push * Run Postman Collection Once All Docker Images are built (#50) * Added Postman collection and env variables * Update ci.yml to run postman collections Co-authored-by: Roshan Piyush <roshan.piyush@traceable.ai> * Dynamic Ports for Identity, Community and Workshop services (#49) * Added dynamic port settings for Identity service * Added dynamic port settings for Community service * Added dynamic port settings for Workshop service * Added default port numbers for the services * Version Variable for Windows (#53) * Set version env variable for docker-compose * Increased memory limit for crapi-identity container (#57) * Openapi Spec Added (#58) Co-authored-by: mathew-jose <mathewjose2409@gmail.com> * Update Vagrant to use prebuilt images and fix db versions (#59) * Update Vagrant to use prebuilt images * Fix mongo and postgres version * Update latest on main merge (#60) Update latest tag on main merge * Release created -> published (#62) Release created -> published Co-authored-by: mathew-jose <mathewjose2409@gmail.com> Co-authored-by: Nikhil R <mail@nikhilrajesh.com> Co-authored-by: Mathew Jose Mammoottil <60283272+mathew-jose@users.noreply.github.com> Co-authored-by: Nikhil R <nikhilr.v2.0@gmail.com> Co-authored-by: PauloASilva <pauloasilva@gmail.com> Co-authored-by: Jayesh Bapu Ahire <jayeshbahire@gmail.com> Co-authored-by: Jayesh Bapu Ahire <jayeshbahire@gmail.coml> Co-authored-by: willmccardell <33265548+willmccardell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pull request to fix #56 . This will make it more likely for docker-compose to work to start the crAPI services.
Initially I fixed this with 512M, but since the original limit was 256M I changed it to 384M just to keep it lighter weight.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested the service locally.
Testing involved 2 different machines, one local VM and one VM in AWS.
Steps taken to test:
Repeated the docker-compose down then docker-compose up commands a few times to on each machine to ensure it wasn't a fluke.
Checklist: