Fixes https://github.com/OWASP/crAPI/issues/6 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Pull author information dynamically from Postgres
Description
Changes:
Grab LOB from Postgres and convert into base64 encoded avatar string when making a post or comment
Store string in mongo for return as profile_pic_url
Fix web ui; should have been url || default, not default || url
Note: Author information really should be set up to dynamically pull from postgres instead. Any chnange to user information (name, avatar, email, etc) won't be reflected.
Testing
Staged a crAPI environment and then used a baseline script to build out 10,000 users, and then used faker to set their avatar and make posts + comments
Documentation
Make sure that you have documented corresponding changes in this repository.
Checklist: