-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proofreading fixes 0x05d part 3 #2413
Conversation
Typos, poor English
|
||
- Check if the key attestation is totally implemented at the client-side. In such scenario, the same can be easily bypassed by tampering the application, method hooking, etc. | ||
- Check if the key attestation is totally implemented on the client-side. In such scenario, the same can be easily bypassed by tampering the application, method hooking, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you want to say here??
"In such scenario, the same can be easily bypassed by tampering the application, method hooking, etc."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this is not clear at all. I would assume that whoever wow this was trying to say something like "it's important to check whether the key attestation is implemented entirely on the client side (i.e., within the application itself), because if it is, then it can be more easily bypassed by attackers". The recommendation would be to implement the server side counterpart as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cpholguera. Let's have a go at it then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to change it more. Maybe use some text from my comment. I feel the current version is still missing something :/
As per suggestion, to solve linting issue Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
For understandability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Laancelot and sorry for the delay!
Typos, poor English, links
Thank you for submitting a Pull Request to the OWASP MASTG. Please make sure that:
If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #< insert number here >.