Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turkish translation #561

Merged
merged 24 commits into from
Jan 27, 2023
Merged

Conversation

haktanemik
Copy link
Contributor

Thank you for submitting a Pull Request to the Mobile Application Security Verification Standard. Please make sure that:

  • Your PR is linked to an issue.
  • Your PR follows the contribution guidelines
  • All links are valid and use HTTPS and have been formatted as [TEXT](URL “NAME”)
  • In case of a translation: have you made sure that the translation from EN is as close to the EN document as possible?

This PR covers issue #560 .

If your pull-request has a focus of rewriting a requirement and/or adding a new one, please make sure you have a backing issue in which your change has been discussed and agreed. If there is none, then your PR will be closed without further review.

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @haktanemik! What an excellent surprise. Thanks to your contribution we cover now 14 languages 🎉

Thank you very much for the hard work, once we merge it we will announce it on Twitter, LinkedIn and Slack. Would you like us to mention you directly? If yes, please send us your handles for the different platforms.

@haktanemik
Copy link
Contributor Author

Hi @cpholguera,

Thanks a lot for fast and kind your response. We would be very pleased if you mention about us. We made this translation with my friend Anıl.

Twitter usernames are @haktanemik and @0x4n1l
Linkedin usernames are @haktanemik and @anilbas1

Thank you very much.

@cpholguera
Copy link
Collaborator

That's awesome, we will definitely mention you both!

The process goes like this: now we require a second approval from an independent target language speaker. We're currently searching for one. After that we'll merge and announce :)

Meanwhile I just need you to do one little thing. Could you please git pull origin master and then git push. I've fixed the linting and URL checking errors and with this your PR will show all green. Thanks in advance!

And thanks a lot to Anıl as well!

@Glassware123
Copy link
Contributor

Hi @cpholguera,

I've fixed markdown issues. Thanks in advance!

Regards,
Anıl

@cpholguera cpholguera self-requested a review November 3, 2021 16:08
Document-tr/0x01-Foreword.md Show resolved Hide resolved
Document-tr/0x02-Frontispiece.md Show resolved Hide resolved
Document-tr/0x03-Using_the_MASVS.md Show resolved Hide resolved
Document-tr/0x90-Appendix-A_Glossary.md Show resolved Hide resolved
Document-tr/0x91-Appendix-B_References.md Show resolved Hide resolved
Document-tr/CHANGELOG.md Show resolved Hide resolved
Document-tr/GLOSSARY.md Show resolved Hide resolved
Document-tr/SUMMARY.md Show resolved Hide resolved
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @haktanemik! And apologies for the delay. We were focusing on the MASVS refactoring as you might know. Thank you very much!

@cpholguera cpholguera merged commit 0be0b7b into OWASP:master Jan 27, 2023
@Glassware123
Copy link
Contributor

Hi @cpholguera,

Thanks for great news! Have a nice day.

Best regards.

@Glassware123 Glassware123 deleted the TurkishTranslation branch January 30, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants