updating V7-Code_quality_and_build_setting_requirements.md #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushi2k
reviewed
Dec 15, 2016
| @@ -9,13 +9,14 @@ The goal of this control is to ensure that basic security coding practices are f | |||
| | # | Description | 1 | 2 | 3 | 4 | | |||
| | --- | --- | --- | --- | --- | --- | | |||
| | **7.1** | Verify that the application catches and handles possible exceptions.| ✓ | ✓ | ✓ | ✓ | | |||
| | **7.2** | Verify that all debugging code is removed from the release build, and that the app does log detailed error messages. | ✓ | ✓ | ✓ | ✓ | | |||
| | **7.2** | Verify that all debugging code is removed from the release build, and that the app does log detailed error messages. (e.g ADB logcat, NSLog)| ✓ | ✓ | ✓ | ✓ | | |||
There was a problem hiding this comment.
This requirement is missing a NOT:
Verify that all debugging code is removed from the release build, and that the app does NOT log detailed error messages.
There was a problem hiding this comment.
I think examples are not needed, as we want to stay consistent throughout the MASVS. If we put examples here we should have them everywhere. Details for this will be outlined in the MSTG (https://github.com/OWASP/owasp-mstg)
| | **7.3** | Verify that error handling logic in security controls denies access by default. | ✓ | ✓ | ✓ | ✓ | | ||
| | **7.4** | Do not concatenate untrusted external input into database queries or dynamically executed code. | ✓ | ✓ | ✓ | ✓ | | ||
| | **7.5** | If the app contains unmanaged code, verify that memory is allocated, freed and used securely. | ✓ | ✓ | ✓ | ✓ | | ||
| | **7.6** | Verify that the app is marked as a release build. | ✓ | ✓ | ✓ | ✓ | | ||
| | **7.7** | Verify that security features offered by the compiler, such as stack protection, PIE support and automatic reference counting, are activated. | ✓ | ✓ | ✓ | ✓ | | ||
| | **7.8** | Verify that static and dynamic application security testing are performed as part of the development lifecycle, and that the configuration of the SAST and DAST tools is tailored to the app. | | ✓ | ✓ | ✓ | | ||
| | **7.9** | Verify that App must be code signed and provisioned with valid certificate. | | ✓ | ✓ | ✓ | |
There was a problem hiding this comment.
I would say that this is a Level 1 requirement, as these are the fundamental security principles of iOS and Android that you can only install an App if it is signed correctly.
This was referenced Dec 15, 2016
commjoen
pushed a commit
that referenced
this pull request
Jun 4, 2019
updating V7-Code_quality_and_build_setting_requirements.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.