-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BaseRBAC: Create a 'getList()' method #9
Comments
That would be a heavy function. It would be nicer to use yield, to reduce memory consumption specially for all permissions. Notice: This message is digitally signed, its source and integrity are verifiable. On Shahrivar 1, 1392, at 1:53 PM, Jesse Burns notifications@github.com wrote:
|
Yes, not a simple one there. I'm going to put this one on the back burner until I can address any open issues and finish creating unit tests for the existing code base. Once that is finished I'll create a topic branch for this issue and work out a proposal for you to review. |
I think a good solution would be to add a note on PHPDOC, saying that this is memory consuming on PHP 5.3- on PHP 5.4+, you can use the yield statement to create a generator. Notice: This message is digitally signed, its source and integrity are verifiable. On Shahrivar 1, 1392, at 7:19 PM, Jesse Burns notifications@github.com wrote:
|
Generators are only supported for PHP 5 >= 5.5.0, but that is a good alternative to use if available. Thanks for the suggestion! |
Right now there are no methods to get/return all Roles/Permissions.
I think a good addition to the BaseRBAC class would be a 'getList()' method that does just that.
Alternative proposed names:
The text was updated successfully, but these errors were encountered: