-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 96 - Rename everything without spaces or brackets #97
Conversation
Any suggestions on what I should be looking at in this frighteningly large pull request? I'm not about to spend an entire day validating that we did indeed remove every space or URL encoded space from every file name in the system: that's what scripting is for. In the future, for something that should be enforced through the entire project, we should make a build script (that will initially fail), and then make modifications until the script passes. EDIT: After a bunch of text communication fails I've had in my experience, I should clarify that I'm not just !@#$ing and complaining. (Unfortunately I've run into people who automatically translate any criticism or suggestion into "The person at the other side of the conversation hates me.", and in text communication it's even worse because there is no non-verbal component aside from capital letters and emoji.) I make heavy use of counterexamples to push a point, and I know some personality types get "set off" as a false positive for a direct insult. That heavy bit aside, I'd be happy to do scripting for verification if that's what's needed - I've been making test scripts since 2009 ... just I'd have to find which scripts work on markdown to be able to put together a CI for it... The worst case scenario is a script (e.g. Jekyll) transforms the markdown into HTML pages in a Docker container running an HTTP server, and we have a web crawler poke around it. That seems quite Rube-Goldberg though. |
Thank you Patrick for your proposal. We can discuss this and set up some CI tests. I'll be validating the file names as a starting point. We didn't want to resort to scripting as we didn't want to have any issues at the start and we wanted it fast before more commits were done with the name files. |
Here's the structure/names after the changes: Repo tree (click the triangle to expand):
|
|
Rename everything, fix links, fix images. Fixes #96 Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kingthorin The job you've done ... Thank you.
document/4_Web_Application_Security_Testing/4 Web Application Penetration Testing.md
Outdated
Show resolved
Hide resolved
...esting/4.2_Information_Gathering/4.2.8_Fingerprint_Web_Application_Framework_OTG-INFO-008.md
Show resolved
Hide resolved
From the tree, and the dead URLs, I think the below needs fixing:
|
Updated tree
|
Done. (I think) |
There is only one left: 4.3 Configuration and Deployment Management Testing |
Boom, done. 4.3 Changed
|
This PR covers issue #96.
What did this PR accomplish?
Rename everything, fix links, fix images.
Note: I specifically didn't update the v4 ToC content. IMHO it should be removed and recreated later when we're ready/closer to release.
Fixes #96