Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adopt first implementor's draft #6

Merged
merged 63 commits into from
Jul 31, 2024
Merged

adopt first implementor's draft #6

merged 63 commits into from
Jul 31, 2024

Conversation

moratori
Copy link
Member

@moratori moratori commented Jun 13, 2024 •
edited
Loading

Purpose

  • Modifications were made to comply with the implementer draft. The main changes are as shown in the figure below.

ID1

Main changes

  • To validate the data structure, a JSON schema was created and Ajv was installed for validation.
  • The metadata structure has been updated to comply with the latest specifications.
  • When responding with metadata, Accept-Language is now interpreted as an option.

@moratori
Fixed the ignore file due to changes in directory hierarchy.
a09c131
@moratori
Fixed due to changes in the data structure of proof_types_supported.
89dccbd
@moratori
renamed cryptographic_suites_supported to credential_signing_alg_valu…
37329ac 
…es_supported to clarify the purpose of the parameter
@moratori
Fixed to cache metadata in memory.
92938df
@moratori
Run prettier
b3cd539
@moratori
Define data types related to IssuerMetadata
1f4824a
@moratori
Generate schema for issuer metadata.
e9184aa
@moratori
Implemented localization of IssuerMetadata.
3f36163
@moratori
Added new dependencies related to metadata loading and localization.
97ee165
@moratori
Add --required option.
e4da235
@moratori
Improved data type accuracy
08a7c5e
@moratori
Fixed to conform to the latest metadata types.
cb9df2b
@moratori
Fixed to include JSON schema files in build artifacts.
b7c987e
@moratori
Fixed to interpret Accept-Language when requesting metadata.
c681b24
@moratori
Fixed locale identifier.
7ab3a64
@moratori
Ideally, it should be implemented by calling common functions, but `p…
abc56b2 
…roxy-vci` is not prepared in advance for that, so the implementation on the library side will be ported to `proxy-vci`.
@moratori
Fixed locale identifier.
e6a34ac
@moratori
Fixed to receive resolved result as locale string.
47f5b56
@moratori moratori self-assigned this Jun 13, 2024
@moratori moratori marked this pull request as draft June 13, 2024 12:28
@moratori
Improved accuracy of Proof type.
97f9cfe
@moratori
Fix validateProof to use Proof as the argument type. Also, modifi…
aa20a6f 
…ed the type naming to make it clear that the data is after JWT decoding.
@moratori
Removed untestable case (because proof_type is guaranteed to exist …
4bdc025 
…when running `validateProof`).
@moratori
Add eslint comment.
ebf0df2
@moratori
Reinstall as devDependency.
8861075
@moratori
Add tests.
e2daa65
@moratori
Fixed a bug related to HTTP Body retrieval.
b686cce
@moratori
Fixed an issue where schema under dist could not be loaded properly.
ea25165
@moratori
Fixes to keep up with changes in the library.
4c44f65
@moratori
Changes due to reinstallation.
c97e77a
@moratori
Fixes to keep up with changes in the library.
40427da
@moratori
Remove unnecessary checks. (Because the type definition guarantees th…
829d8b0 
…at it is not undefined.)
@moratori
Fixes to keep up with changes in the library.
d9ce75c
@moratori
Modification of test cases due to changes in request data checking lo…
5d79102 
…gic.
@moratori
Changes due to reinstallation.
f2c9b8a
@moratori
Run prettier
13e6277
@moratori moratori marked this pull request as ready for review June 18, 2024 01:01
@moratori moratori changed the title WIP adopt first implementer's draft adopt first implementer's draft Jun 18, 2024
@moratori moratori changed the title adopt first implementer's draft adopt first implementor's draft Jun 18, 2024
@moratori moratori changed the base branch from main to develop July 16, 2024 11:52
ryosuke-wakaba
ryosuke-wakaba reviewed Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@ryosuke-wakaba ryosuke-wakaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some simple things to check, so please check them.

src/oid4vci/types/validator.ts Show resolved Hide resolved
src/oid4vci/types/validator.ts Show resolved Hide resolved
@moratori
Copy link
Member Author

Upon reconsideration, I feel that the timing of the validation might be inappropriate.
I'll think about whether it's possible to perform the validation at an earlier stage.

@moratori
Copy link
Member Author

In conclusion, I would like to keep the current implementation.
During the _issue process, the processing is performed according to the credential format, making it convenient to perform format-specific validation at that time.

ryosuke-wakaba
ryosuke-wakaba approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@ryosuke-wakaba ryosuke-wakaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/oid4vci/types/validator.ts Show resolved Hide resolved
src/oid4vci/types/validator.ts Show resolved Hide resolved
@ryosuke-wakaba ryosuke-wakaba merged commit 733a115 into OWND-Project:develop Jul 31, 2024
4 checks passed
@moratori moratori deleted the adopt-first-implementors-draft branch November 14, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryosuke-wakaba ryosuke-wakaba ryosuke-wakaba approved these changes

Assignees

@moratori moratori

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moratori @ryosuke-wakaba