Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace geth crypto package #1626

Closed
corverroos opened this issue Jan 13, 2023 · 0 comments
Closed

Replace geth crypto package #1626

corverroos opened this issue Jan 13, 2023 · 0 comments
Assignees
@corverroos
Labels
protocol Protocol Team tickets refactor Code refactoring

Comments

@corverroos
Copy link
Contributor

Problem to be solved

As part of the move from GPL license and remove of the go-ethereum dependency, we need to remove uses of the github.com/ethereum/go-ethereum/crypto package.

Proposed solution

Find another library or port the required functionality.
@OisinKyne OisinKyne added the refactor Code refactoring label Jan 16, 2023
@thomasheremans thomasheremans assigned gsora and corverroos and unassigned gsora Jan 18, 2023
@thomasheremans thomasheremans added the protocol Protocol Team tickets label Jan 23, 2023
@corverroos corverroos mentioned this issue Jan 25, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jan 25, 2023
@corverroos
app/k1util: ports geth crypto package helper functions (#1682)
ef2ee39 
Adds a `app/k1util` package that will replace the `geth/crypto` package. The aim is to work with underlying `github.com/decred/dcrd/dcrec/secp256k1/v4` types which is aligned with libp2p's way of doing this:
 - `k1.PrivateKey` to replace `ecdsa.PrivateKey`
 - `k1.PublicKey` to replace `ecdsa.PublicKey`

category: refactor
ticket: #1626
@corverroos corverroos mentioned this issue Jan 25, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jan 26, 2023
@corverroos
*: migrate to k1 package (#1685)
3b79fbc 
Migrates uses of `ecdsa.P*Key` to `k1.P*Key` and uses of `geth/crypto` to `app/k1util`.

category: refactor
ticket: #1626
@corverroos corverroos mentioned this issue Jan 26, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jan 27, 2023
@corverroos
eth2util: implement checksum address (#1694)
f6f959d 
Implements ethereum EIP155 address checksum as part of moving away from geth libraries. Also add an`PublicKeyToAddress` function.

category: refactor
ticket: #1626
@corverroos corverroos mentioned this issue Jan 27, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jan 27, 2023
@corverroos
*: migrate uses of geth code (#1699)
33b03e9 
Port over uses of geth crypto packages.

category: refactor
ticket: #1626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corverroos corverroos

Labels
protocol Protocol Team tickets refactor Code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gsora @OisinKyne @corverroos @thomasheremans