Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relay peerinfo protocol is failing #1956

Closed
corverroos opened this issue Mar 28, 2023 · 0 comments
Closed

Relay peerinfo protocol is failing #1956

corverroos opened this issue Mar 28, 2023 · 0 comments
Assignees
@corverroos
Labels
protocol Protocol Team tickets

Comments

@corverroos
Copy link
Contributor

🐞 Bug Report

Description

Relay peerinfo protocol is failing with latest main peers since they error on 0 length requests.

Proposed Solution

Remove request length check for stream delimited protocols.
@github-actions github-actions bot added the protocol Protocol Team tickets label Mar 28, 2023
This was referenced Mar 28, 2023
Closed
Merged
obol-bulldozer bot pushed a commit that referenced this issue Mar 29, 2023
@corverroos
p2p: support zero length request protos (#1958)
539c34f 
Fix regression introduced by length-delimited upgrades which assumed that legacy-stream-delimited protocols handled requests and responses the same while it didn't. It allowed zero length requests while it didn't allow zero-length responses. This aligns the new implementation with that.

category: bug
ticket: #1956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corverroos corverroos

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@corverroos