core/deadliner: fix deadliner flappy test #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2047 +/- ##
==========================================
+ Coverage 53.40% 53.45% +0.05%
==========================================
Files 174 174
Lines 22481 22513 +32
==========================================
+ Hits 12005 12034 +29
- Misses 8968 8973 +5
+ Partials 1508 1506 -2 see 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
corverroos
approved these changes
Apr 6, 2023
dB2510
added
the
merge when ready
LukeHackett12
pushed a commit
that referenced
this pull request
Apr 11, 2023
Fixes flappy deadliner test. Looks like clockwork.FakeClock is not thread safe. Found out while debugging we were calling `clock.Advance` in deadline_test and `setCurrState` in deadline.go at the same time. category: test ticket: #1721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flappy deadliner test. Looks like clockwork.FakeClock is not thread safe. Found out while debugging we were calling
clock.Advancein deadline_test andsetCurrStatein deadline.go at the same time.category: test
ticket: #1721