core: batch signed data set #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2523 +/- ##
==========================================
+ Coverage 53.70% 53.74% +0.03%
==========================================
Files 199 199
Lines 26908 27029 +121
==========================================
+ Hits 14451 14526 +75
- Misses 10659 10699 +40
- Partials 1798 1804 +6
☔ View full report in Codecov by Sentry. |
dB2510
approved these changes
Aug 9, 2023
| @@ -27,7 +27,7 @@ func TestDutyExpiration(t *testing.T) { | |||
| pubkey := testutil.RandomCorePubKey(t) | |||
| sig := testutil.RandomCoreSignature() | |||
|
|
|||
| err := db.Store(ctx, duty, pubkey, sig) | |||
| err := db.Store(ctx, duty, core.SignedDataSet{pubkey: sig}) | |||
There was a problem hiding this comment.
can also use db.store(...) as it is an internal test
Co-authored-by: Dhruv Bodani <dhruvbodani2510@gmail.com>
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the
core.SignedDataSettype and refactorsigagg,aggSigDBandbcastinterfaces to use it. This supports batching when broadcasting signed data to beacon API which should improve latency and decrease BN load for large clusters.category: feature
ticket: #2373