Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: batch signed data set #2523

Merged
merged 3 commits into from
Aug 9, 2023
Merged

core: batch signed data set #2523

merged 3 commits into from
Aug 9, 2023

Conversation

corverroos
Copy link
Contributor

Introduce the core.SignedDataSet type and refactor sigagg, aggSigDB and bcast interfaces to use it. This supports batching when broadcasting signed data to beacon API which should improve latency and decrease BN load for large clusters.

category: feature
ticket: #2373

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 47.61% and project coverage change: +0.03% 🎉

Comparison is base (d35f366) 53.70% compared to head (573b6e2) 53.74%.
Report is 4 commits behind head on main.

❗ Current head 573b6e2 differs from pull request most recent head a23e52a. Consider uploading reports for the commit a23e52a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2523      +/-   ##
==========================================
+ Coverage   53.70%   53.74%   +0.03%     
==========================================
  Files         199      199              
  Lines       26908    27029     +121     
==========================================
+ Hits        14451    14526      +75     
- Misses      10659    10699      +40     
- Partials     1798     1804       +6     
Files Changed Coverage Δ
app/app.go 6.76% <0.00%> (ø)
core/bcast/recast.go 0.00% <0.00%> (ø)
core/interfaces.go 0.00% <ø> (ø)
core/retry.go 0.00% <0.00%> (ø)
core/tracing.go 14.85% <0.00%> (ø)
core/tracker/inclusion.go 41.06% <0.00%> (-0.80%) ⬇️
core/tracking.go 0.00% <0.00%> (ø)
core/types.go 27.07% <0.00%> (-1.42%) ⬇️
core/tracker/tracker.go 79.51% <44.44%> (-0.08%) ⬇️
core/sigagg/sigagg.go 62.02% <60.60%> (+2.93%) ⬆️
... and 4 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -27,7 +27,7 @@ func TestDutyExpiration(t *testing.T) {
pubkey := testutil.RandomCorePubKey(t)
sig := testutil.RandomCoreSignature()

err := db.Store(ctx, duty, pubkey, sig)
err := db.Store(ctx, duty, core.SignedDataSet{pubkey: sig})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can also use db.store(...) as it is an internal test

core/bcast/bcast.go Outdated Show resolved Hide resolved
Co-authored-by: Dhruv Bodani <dhruvbodani2510@gmail.com>
@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Aug 9, 2023
@obol-bulldozer obol-bulldozer bot merged commit 9a72f8c into main Aug 9, 2023
11 checks passed
@obol-bulldozer obol-bulldozer bot deleted the corver/signeddataset branch August 9, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants