app/stacksnipe: detect validator services #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect Ethereum validator stack components by reading `/proc` and filtering processes based on an allowlist. To support containerized deployments, add `--proc-directory` flag to `charon run`: if not configured, Charon will log an `INFO` message saying it won't do anything. Support detecting interpreted components like `lodestar`. Expose the resulting data through the `app_validator_stack_params` Prometheus metric. By default, poll the specified directory every 15 seconds.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3169 +/- ##
==========================================
- Coverage 56.78% 56.70% -0.08%
==========================================
Files 208 209 +1
Lines 29221 29374 +153
==========================================
+ Hits 16592 16656 +64
- Misses 10802 10877 +75
- Partials 1827 1841 +14 ☔ View full report in Codecov by Sentry. |
pinebit
reviewed
Jul 12, 2024
pinebit
approved these changes
Jul 16, 2024
KaloyanTanev
approved these changes
Jul 18, 2024
| @@ -91,6 +91,7 @@ func bindRunFlags(cmd *cobra.Command, config *app.Config) { | |||
| cmd.Flags().Uint64Var(&config.TestnetConfig.ChainID, "testnet-chain-id", 0, "Chain ID of the custom test network.") | |||
| cmd.Flags().Int64Var(&config.TestnetConfig.GenesisTimestamp, "testnet-genesis-timestamp", 0, "Genesis timestamp of the custom test network.") | |||
| cmd.Flags().StringVar(&config.TestnetConfig.CapellaHardFork, "testnet-capella-hard-fork", "", "Capella hard fork version of the custom test network.") | |||
| cmd.Flags().StringVar(&config.ProcDirectory, "proc-directory", "", "Directory to look into in order to detect other stack components running on the host.") | |||
There was a problem hiding this comment.
Probably we can add an example of such dir?
gsora
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect Ethereum validator stack components by reading
/procand filtering processes based on an allowlist.To support containerized deployments, add
--proc-directoryflag tocharon run: if not configured, Charon will log anINFOmessage saying it won't do anything.Support detecting interpreted components like
lodestar.Expose the resulting data through the
app_validator_stack_paramsPrometheus metric.By default, poll the specified directory every 15 seconds.
category: feature
ticket: none