core/validatorapi: workaround for Gnosis proposals #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsora
force-pushed
the
gsora/gnosis-block-hotfix
branch
2 times, most recently
from
3b17178
to
0b37784
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3238 +/- ##
==========================================
+ Coverage 57.63% 57.70% +0.07%
==========================================
Files 211 211
Lines 30370 30375 +5
==========================================
+ Hits 17503 17528 +25
+ Misses 10982 10962 -20
Partials 1885 1885 ☔ View full report in Codecov by Sentry. |
pinebit
approved these changes
Aug 23, 2024
If the "gnosis_block_hotfix" feature flag is enabled, use the Gnosis-compatible representation of the proposal when calculating its hash tree root. This should fix Gnosis proposals failing due to bad signature.
gsora
force-pushed
the
gsora/gnosis-block-hotfix
branch
from
0b37784
to
320438b
Compare
|
|
|
||
| // We're replacing go-eth2-client with a branch off our fork, at version v0.21.10. | ||
| // This is needed to ensure Gnosis compatibility. | ||
| replace github.com/attestantio/go-eth2-client => github.com/ObolNetwork/go-eth2-client v0.21.11-0.20240822135044-f0a5b21e02c6 |
There was a problem hiding this comment.
Wouldn't that mean we will have to manage this repo constantly and rebase it every time there is a new version of go-eth2-client?
There was a problem hiding this comment.
Hopefully go-eth2-client will fix this upstream soon
KaloyanTanev
approved these changes
Aug 26, 2024
gsora
added
the
merge when ready
pinebit
pushed a commit
that referenced
this pull request
Sep 16, 2024
If the "gnosis_block_hotfix" feature flag is enabled, use the Gnosis-compatible representation of the proposal when calculating its hash tree root. This should fix Gnosis proposals failing due to bad signature. category: feature ticket: #3181 feature_flag: gnosis_block_hotfix
Merged
obol-bulldozer bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
For release v1.1.1 cherry picked: * [core/validatorapi: workaround for Gnosis proposals](#3238) * [*: enable gnosis hotfix automatically](#3257) *: [fix flaky testpeers test #3267](#3267) * [cmd: increase testpeers tests timeouts #3268](#3268) * [cmd: fix test peers out of range #3280](#3280) * [testutil: update docker-compose command to docker compose](#3249) category: misc ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the "gnosis_block_hotfix" feature flag is enabled, use the Gnosis-compatible representation of the proposal when calculating its hash tree root. This should fix Gnosis proposals failing due to bad signature.
category: feature
ticket: #3181
feature_flag: gnosis_block_hotfix