Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: unified create validation #3246

Closed
wants to merge 1 commit into from

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Sep 3, 2024

Unified create cluster and create dkg commands validation:

  • The minimum number of nodes (operators) is 3.
  • The threshold cannot be greater than the number of nodes (operators).

category: refactor
ticket: none

Copy link

sonarcloud bot commented Sep 3, 2024

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.69%. Comparing base (85bd4b1) to head (ededf7e).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3246      +/-   ##
==========================================
+ Coverage   57.63%   57.69%   +0.05%     
==========================================
  Files         211      211              
  Lines       30370    30382      +12     
==========================================
+ Hits        17503    17528      +25     
+ Misses      10982    10968      -14     
- Partials     1885     1886       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit
Copy link
Contributor Author

pinebit commented Sep 3, 2024

Shall be closed in favor of https://github.com/ObolNetwork/charon/pull/3242/files

@pinebit pinebit added the do not merge Indicate to bulldozer bot that this PR should not be merged label Sep 3, 2024
@pinebit pinebit closed this Sep 4, 2024
@pinebit pinebit deleted the pinebit/unified-create-cluster-dkg branch September 5, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicate to bulldozer bot that this PR should not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant