Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charon poc #3

Merged
merged 19 commits into from
Mar 26, 2024
Merged

charon poc #3

merged 19 commits into from
Mar 26, 2024

Conversation

sugh01
Copy link

@sugh01 sugh01 commented Feb 28, 2024

Changes:

Charon is used by stakers to distribute the responsibility of running Ethereum Validators across a number of different instances and client implementations. Setting up and running a full ethereum node with charon, needs some learning curve and compatibility knowledge, in order for the setup to be fully compliant with the charon configuration requirements for different BN-VC combinations. We want to provide a better and guided user experience for setting up a DV with Charon.

Sedge, is a one-click ethereum node setup tool which focuses on ease of use and, as such, lowers the entry barrier for non-technical users. With Sedge, one can run a node or a validator on Ethereum with little to no technical background.
Integrating Charon with Sedge would make it easy for stakers to setup and run a DV with Charon without having to go through each individual client setup docs and their compatibility with DVT.

Please refer Design Doc here - https://docs.google.com/document/d/1nQsOmkd-od3-lej3OcdUgVZ0GYXAHK9GZqlwEoyIzSY/edit

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

@OisinKyne OisinKyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very solid! Couple extra blocks of commented code I would clean if this weren't a poc, and a couple naming suggestions to lean away from charon. (Kept it as the URI and default filename, because a custom more generic one would cause pain).

cli/sub_gen.go Outdated Show resolved Hide resolved
configs/client_images.yaml Outdated Show resolved Hide resolved
internal/pkg/clients/types.go Show resolved Hide resolved
internal/pkg/generate/generate_scripts.go Outdated Show resolved Hide resolved
templates/services/merge/distributedValidator/charon.tmpl Outdated Show resolved Hide resolved
configs/paths.go Outdated Show resolved Hide resolved
@sugh01 sugh01 marked this pull request as ready for review March 25, 2024 03:51
Copy link

@OisinKyne OisinKyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, made some changes maybe worth considering.

templates/services/merge/distributedValidator/charon.tmpl Outdated Show resolved Hide resolved
templates/services/merge/distributedValidator/charon.tmpl Outdated Show resolved Hide resolved
templates/services/merge/distributedValidator/charon.tmpl Outdated Show resolved Hide resolved
configs/constants.go Outdated Show resolved Hide resolved
cli/actions/generation_test.go Outdated Show resolved Hide resolved
internal/pkg/generate/generate_scripts_test.go Outdated Show resolved Hide resolved
@sugh01 sugh01 merged commit c141758 into develop Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants