Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Region file hotfix #365

Merged
merged 5 commits into from
Jun 4, 2023
Merged

Region file hotfix #365

merged 5 commits into from
Jun 4, 2023

Conversation

Tides
Copy link
Member

@Tides Tides commented Jun 4, 2023 •
edited
Loading

Fixes all of the problems we were facing with current implementation

NOTE This does not support moving oversized chunks (chunks bigger than 1MB) to its own file (r.x.z.mcc) yet. Will do that in another pr

@github-actions github-actions bot added the nbt Relates to Obsidian.Nbt label Jun 4, 2023
@Tides Tides added epic Very cool world generation Relates to world generation priority: blocking Blocking; must be prioritized labels Jun 4, 2023
Jonpro03
Jonpro03 approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@Jonpro03 Jonpro03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine

@Jonpro03 Jonpro03 merged commit d47162f into master Jun 4, 2023
2 checks passed
@Jonpro03 Jonpro03 deleted the hotfix/region-file branch June 4, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonpro03 Jonpro03 Jonpro03 approved these changes

Assignees
No one assigned
Labels
epic Very cool nbt Relates to Obsidian.Nbt priority: blocking Blocking; must be prioritized world generation Relates to world generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tides @Jonpro03