Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script only adds first custom anki note from file #114

Closed
martinsondergaard opened this issue Dec 9, 2020 · 6 comments
Closed

Script only adds first custom anki note from file #114

martinsondergaard opened this issue Dec 9, 2020 · 6 comments

Comments

@martinsondergaard
Copy link

If I have multiple custom anki notes in a single .md file only the first note is added to anki.

I have made a custom cloze note type with fields ObsidianLink, Text, and Remarks. The ObsidianLink field is first and only used for the automatic adding of obsidian://vault links.

I have tested two files: one with multiple custom notes and one with multiple basic notes. Here is the result:

START
Basic
Front1
Back: Back1
<!--ID: 1607536658626-->
END

START
Basic
Front2
Back: Back2
<!--ID: 1607536658636-->
END

START
Basic
Front3
Back: Back3
<!--ID: 1607536658645-->
END
START
ClozeObsidian
Text: Text1 {cloze}
Remarks: Remarks1
<!--ID: 1607536658658-->
END

START
ClozeObsidian
Text: Text2 {cloze}
Remarks: Remarks2
END

START
ClozeObsidian
Text: Text3 {cloze}
Remarks: Remarks3
END

As you can see only the first of the custom notes have been added. Maybe the requests to AnkiConnect are malformed, but I don't know enough about AnkiConnect to figure out what is wrong.

I have added a print of the two requests dictionaries being sent to AnkiConnect. Not sure why the script is sending so many empty requests.

[{'action': 'getTags', 'params': {}, 'version': 6},
 {'action': 'multi', 'params': {'actions': []}, 'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': [{'action': 'addNotes',
                                                  'params': {'notes': [{'audio': [],
                                                                        'deckName': 'All::Main',
                                                                        'fields': {'Back': 'Back1',
                                                                                   'Front': 'Front1<br><a '
                                                                                            'href="obsidian://vault/notes/Anki '
                                                                                            'Test '
                                                                                            '2.md" '
                                                                                            'class="obsidian-link">Obsidian</a>'},
                                                                        'modelName': 'Basic',
                                                                        'options': {'allowDuplicate': False,
                                                                                    'duplicateScope': 'deck'},
                                                                        'tags': ['obsidian',
                                                                                 '']},
                                                                       {'audio': [],
                                                                        'deckName': 'All::Main',
                                                                        'fields': {'Back': 'Back2',
                                                                                   'Front': 'Front2<br><a '
                                                                                            'href="obsidian://vault/notes/Anki '
                                                                                            'Test '
                                                                                            '2.md" '
                                                                                            'class="obsidian-link">Obsidian</a>'},
                                                                        'modelName': 'Basic',
                                                                        'options': {'allowDuplicate': False,
                                                                                    'duplicateScope': 'deck'},
                                                                        'tags': ['obsidian',
                                                                                 '']},
                                                                       {'audio': [],
                                                                        'deckName': 'All::Main',
                                                                        'fields': {'Back': 'Back3',
                                                                                   'Front': 'Front3<br><a '
                                                                                            'href="obsidian://vault/notes/Anki '
                                                                                            'Test '
                                                                                            '2.md" '
                                                                                            'class="obsidian-link">Obsidian</a>'},
                                                                        'modelName': 'Basic',
                                                                        'options': {'allowDuplicate': False,
                                                                                    'duplicateScope': 'deck'},
                                                                        'tags': ['obsidian',
                                                                                 '']}]},
                                                  'version': 6},
                                                 {'action': 'addNotes',
                                                  'params': {'notes': [{'audio': [],
                                                                        'deckName': 'All::Main',
                                                                        'fields': {'ObsidianLink': '<br><a '
                                                                                                   'href="obsidian://vault/notes/Anki '
                                                                                                   'Test.md" '
                                                                                                   'class="obsidian-link">Obsidian</a>',
                                                                                   'Remarks': 'Remarks1',
                                                                                   'Text': 'Text1 '
                                                                                           '{{c1::cloze}}'},
                                                                        'modelName': 'ClozeObsidian',
                                                                        'options': {'allowDuplicate': False,
                                                                                    'duplicateScope': 'deck'},
                                                                        'tags': ['obsidian',
                                                                                 '']},
                                                                       {'audio': [],
                                                                        'deckName': 'All::Main',
                                                                        'fields': {'ObsidianLink': '<br><a '
                                                                                                   'href="obsidian://vault/notes/Anki '
                                                                                                   'Test.md" '
                                                                                                   'class="obsidian-link">Obsidian</a>',
                                                                                   'Remarks': 'Remarks2',
                                                                                   'Text': 'Text2 '
                                                                                           '{{c1::cloze}}'},
                                                                        'modelName': 'ClozeObsidian',
                                                                        'options': {'allowDuplicate': False,
                                                                                    'duplicateScope': 'deck'},
                                                                        'tags': ['obsidian',
                                                                                 '']},
                                                                       {'audio': [],
                                                                        'deckName': 'All::Main',
                                                                        'fields': {'ObsidianLink': '<br><a '
                                                                                                   'href="obsidian://vault/notes/Anki '
                                                                                                   'Test.md" '
                                                                                                   'class="obsidian-link">Obsidian</a>',
                                                                                   'Remarks': 'Remarks3',
                                                                                   'Text': 'Text3 '
                                                                                           '{{c1::cloze}}'},
                                                                        'modelName': 'ClozeObsidian',
                                                                        'options': {'allowDuplicate': False,
                                                                                    'duplicateScope': 'deck'},
                                                                        'tags': ['obsidian',
                                                                                 '']}]},
                                                  'version': 6}]},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': [{'action': 'multi',
                                                  'params': {'actions': []},
                                                  'version': 6},
                                                 {'action': 'multi',
                                                  'params': {'actions': []},
                                                  'version': 6}]},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': [{'action': 'notesInfo',
                                                  'params': {'notes': []},
                                                  'version': 6},
                                                 {'action': 'notesInfo',
                                                  'params': {'notes': []},
                                                  'version': 6}]},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': [{'action': 'deleteNotes',
                                                  'params': {'notes': []},
                                                  'version': 6},
                                                 {'action': 'deleteNotes',
                                                  'params': {'notes': []},
                                                  'version': 6}]},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6}]
[{'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': [{'action': 'changeDeck',
                                                  'params': {'cards': [],
                                                             'deck': 'All::Main'},
                                                  'version': 6},
                                                 {'action': 'changeDeck',
                                                  'params': {'cards': [],
                                                             'deck': 'All::Main'},
                                                  'version': 6}]},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': [{'action': 'removeTags',
                                                  'params': {'notes': [],
                                                             'tags': 'marked '
                                                                     'obsidian '
                                                                     },
                                                  'version': 6},
                                                 {'action': 'removeTags',
                                                  'params': {'notes': [],
                                                             'tags': 'marked '
                                                                     'obsidian '
                                                                     },
                                                  'version': 6}]},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': [{'action': 'multi',
                                                  'params': {'actions': []},
                                                  'version': 6},
                                                 {'action': 'multi',
                                                  'params': {'actions': []},
                                                  'version': 6}]},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6},
 {'action': 'multi',
  'params': {'actions': [{'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6},
                         {'action': 'multi',
                          'params': {'actions': []},
                          'version': 6}]},
  'version': 6}]

And for good measure here is my config file:

[Cloze Note Types]
Art = False
Basic = False
Basic (and reversed card) = False
Basic (optional reversed card) = False
Basic (type in the answer) = False
Cloze = True
Image Occlusion Enhanced = False
ClozeObsidian = True

[Custom Regexps]
Art = 
Basic = 
Basic (and reversed card) = 
Basic (optional reversed card) = 
Basic (type in the answer) = 
Cloze = 
Image Occlusion Enhanced =
ClozeObsidian = 

[Syntax]
Begin Note = START
End Note = END
Begin Inline Note = STARTI
End Inline Note = ENDI
Target Deck Line = TARGET DECK
File Tags Line = FILE TAGS
Delete Regex Note Line = DELETE
Frozen Fields Line = FROZEN

[Obsidian]
Vault name = notes
Add file link = True

[Defaults]
Tag = obsidian
Deck = All::Main
CurlyCloze = True
GUI = False
Regex = False
ID Comments = True
Anki Path = 
Anki Profile =
@Pseudonium
Copy link
Collaborator

Ah, this was tricksy! Took me a while to figure out.

First of all, your config file tells me that you aren't using the latest version of the script?

Also, don't worry about the requests, it's designed so that the script is efficient when adding cards from many, many files. If I had to send a separate HTTP request for every single note, it'd probably take hours for the amount of notes I have. Instead it only takes around 10 mins (or thereabouts).

Anyway, the actual problem is that the script isn't adding the second and third cards because AnkiConnect considers them as 'duplicates' - the 'ObsidianLink' field must be the same for all of them, right? And it's using that first field as the field to check for duplicates.

You might be able to change which field is used for checking duplicates in Anki itself?

@martinsondergaard
Copy link
Author

That was exactly the problem! Seems obvious now :)

It would be great if it was possible to specify a separate field to add the obsidian link to instead of only appending it to the first field. But for now it works fine.

Regarding the requests, I agree that you shouldn't send separate requests for each note. But it looks like the script is generating these large lists of requests, but most of the requests are just empty actions, which I assume don't do anything. It doesn't really matter as the long as the script works, but it makes it a bit more difficult to inspect what is going on.

Thanks for the help and thanks for a great script!

@Pseudonium
Copy link
Collaborator

Yeah, that might be a nice idea. I am wary of adding too much in the way of settings, but once I get this ported over as an actual obsidian plugin that should be fine.

The main problem with the requests is that AnkiConnect doesn’t propagate errors when you bundle a bunch of requests into one request - so the script cannot at all tell what the error was if no ID was returned! One option might be to allow the script to add duplicates...

Each of those requests does serve a purpose for more complicated script actions - such as changing deck, updating fields, changing tags etc. For a simple one, they are often all empty! And I agree it makes it difficult to inspect - it would be much easier if AnkiConnect actually propagated the error. Perhaps this is an issue I can raise with them.

@Pseudonium
Copy link
Collaborator

Pseudonium commented Dec 10, 2020 •
edited
Loading

Actually, hold on! It seems that I might be able to fix this error nicely!

Details - so in the AnkiConnect API, there is an 'addNote' action and a 'addNotes' action. For 'addNote', you specify a single note (which is some dictionary), and for 'addNotes' you specify an array of such notes.

Now, if we tried to do this with 3 addNote requests, we'd get an error for each - "can't add note because it's empty!". That's provided by AnkiConnect, no problems there.

But for some reason, when this is bunched up into a single 'addNotes' request, we no longer get an error! Instead, we just get the identifier returned as 'null'. That's annoying!

However, there is a general-purpose 'multi' in the AnkiConnect library, that allows you to bundle multiple actions into a single action. And it turns out that 'multi' does preserve error messages! So if I can rewrite the code to make use of 'multi' rather than 'addNotes', I should be able to properly display error messages.

Thanks for raising this issue - if I can manage to change it to use 'multi', we'll have improved the experience for future users!

And I've opened an issue on AnkiConnect to warn future devs - FooSoft/anki-connect#212 (comment)

@Pseudonium
Copy link
Collaborator

Pseudonium commented Dec 10, 2020 •
edited
Loading

Yep, I've changed this functionality now! Wasn't that hard to fix actually. So the next version of the script should now properly show error messages. Though I haven't yet implemented proper error-handling - haven't had to yet!

@Pseudonium
Copy link
Collaborator

This should be fixed now. I would highly recommend checking out the new Obsidian plugin version of the script, it allows you to actually configure the field to add the link to.

@Quasimurdock Quasimurdock mentioned this issue Aug 7, 2023
Closed
ShootingKing-AM added a commit that referenced this issue Jan 5, 2024
@ShootingKing-AM @dependabot @serpro69
Implement end to end plugins tests and fixes (#419)
6a6bfbb 
* Update README.md

* Update codeql-analysis.yml

* [CI] Create Release (#2)

* Create Release

* Rename Release to obsidian release.yml

* Update obsidian release.yml

* Update package-lock.json (#3)

* Update and rename obsidian release.yml to obsidian-release.yml

* Update obsidian-release.yml

* Update obsidian-release.yml

* Update manifest.json (#4)

* Update manifest.json

* Update versions.json

* Update obsidian-release.yml

* Update obsidian-release.yml

* Update obsidian-release.yml

* Create dependabot.yml (#5)

* Rename .github/workflows/dependabot.yml to .github/dependabot.yml

* Revert "Update README.md"

This reverts commit 4a8bad4.

* Fix #409 (#8)

* De-clutter release page (#10)

* Fix and update Dependabot (#11)

* Bump actions/checkout from 2 to 3 (#12)

Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/setup-node from 1 to 3 (#14)

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 1 to 3.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v1...v3)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [CI] Build workflow (#19)

* [CI] Build workflow
* Update build.yml

* [CI] Implement end-to-end tests (#21)

- Updated build yml
- e2e with Webdriver IO, Docker and Mocha
- JUnit tests reports to be published on PR

* Create .gitattributes (#23)

* Tweak test-e2e for github-actions (#22)

* Update autostart script
* Update to sh
* Add pytest to dev dependency
* Fixes
* tweak permissions for github
* Update test-e2e.yml
* more verbose
* fix permissions on github actions
* Update obsidian_anki.sh
* Update package.json
* Update test-e2e.yml

* Update test-e2e.yml (#24)

* Update test-e2e.yml

* Update test-e2e.yml

* Update test-e2e.yml (#26)

* Enable fork write actions (#27)

* Fix signed checkout Test (#28)

* Update test-e2e.yml

* Update test-e2e.yml

* Update test-e2e.yml

* Update test-e2e.yml

* [Test] Add supports for multiple tests per worker

- Added e2e Test for inline notes

* [Test] Multiple tests supports and basic_para test

* [Test] Implement regex para highlight cloze e2e tests

- made Obisidan wait to lauch till test files are in its dir

* [Fix] Create decks before pushing cards

- Should fix #9

* [Tests] Fix anki connect to autosave post deleteNote

* [Test] Implement folder_vaults folder_tags update and delete tests

- added default Ctrl+Shift+R shortcut in Docker to run obsidian

* [Test] Implemented image markdown_table_regex math sync tests

* [Test] Implement frozen_notes music neurachahce ruled remnote qna style tests

- tag_sync test
-

* [Test] Cleanup

* [Test] Change CI for multiple tests

* make empty folders ignored by git

* Cleanup

* Update test-e2e.yml

* Update test-e2e.yml

* Update template.e2e.ts

* Extra info for failure

* Update test-e2e.yml

* prepare to fix

* Update test-e2e.yml

* Update test-e2e.yml

* Update template.e2e.ts

* Update test-e2e.yml

* Update reset_perms

* Update test-e2e.yml

* Update template.e2e.ts

* Update autostart

* Update autostart

* reset config

* Update wdio.conf.ts

* Update wdio.conf.ts

* Update wdio.conf.ts

* update perms

* Update wdio.conf.ts

* Bump @types/node from 14.18.36 to 18.15.3 (#34)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.18.36 to 18.15.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump showdown-highlight from 2.1.8 to 3.1.0 (#18)

Bumps [showdown-highlight](https://github.com/Bloggify/showdown-highlight) from 2.1.8 to 3.1.0.
- [Release notes](https://github.com/Bloggify/showdown-highlight/releases)
- [Commits](Bloggify/showdown-highlight@2.1.8...3.1.0)

---
updated-dependencies:
- dependency-name: showdown-highlight
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump showdown and @types/showdown (#16)

Bumps [showdown](https://github.com/showdownjs/showdown) and [@types/showdown](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/showdown). These dependencies needed to be updated together.

Updates `showdown` from 1.9.1 to 2.1.0
- [Release notes](https://github.com/showdownjs/showdown/releases)
- [Changelog](https://github.com/showdownjs/showdown/blob/master/CHANGELOG.md)
- [Commits](showdownjs/showdown@1.9.1...2.1.0)

Updates `@types/showdown` from 1.9.4 to 2.0.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/showdown)

---
updated-dependencies:
- dependency-name: showdown
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: "@types/showdown"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump devtools from 8.5.5 to 8.6.0 (#39)

Bumps [devtools](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/devtools) from 8.5.5 to 8.6.0.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.6.0/packages/devtools)

---
updated-dependencies:
- dependency-name: devtools
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @wdio/local-runner from 8.5.4 to 8.6.0 (#37)

Bumps [@wdio/local-runner](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-local-runner) from 8.5.4 to 8.6.0.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.6.0/packages/wdio-local-runner)

---
updated-dependencies:
- dependency-name: "@wdio/local-runner"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @rollup/plugin-typescript from 6.1.0 to 11.0.0 (#38)

Bumps [@rollup/plugin-typescript](https://github.com/rollup/plugins/tree/HEAD/packages/typescript) from 6.1.0 to 11.0.0.
- [Release notes](https://github.com/rollup/plugins/releases)
- [Changelog](https://github.com/rollup/plugins/blob/master/packages/typescript/CHANGELOG.md)
- [Commits](https://github.com/rollup/plugins/commits/commonjs-v11.0.0/packages/typescript)

---
updated-dependencies:
- dependency-name: "@rollup/plugin-typescript"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @wdio/mocha-framework from 8.4.0 to 8.5.6 (#36)

Bumps [@wdio/mocha-framework](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-mocha-framework) from 8.4.0 to 8.5.6.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.5.6/packages/wdio-mocha-framework)

---
updated-dependencies:
- dependency-name: "@wdio/mocha-framework"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump glob from 9.2.1 to 9.3.0 (#42)

Bumps [glob](https://github.com/isaacs/node-glob) from 9.2.1 to 9.3.0.
- [Release notes](https://github.com/isaacs/node-glob/releases)
- [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md)
- [Commits](isaacs/node-glob@v9.2.1...v9.3.0)

---
updated-dependencies:
- dependency-name: glob
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @wdio/cli from 8.5.1 to 8.6.0 (#41)

Bumps [@wdio/cli](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-cli) from 8.5.1 to 8.6.0.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.6.0/packages/wdio-cli)

---
updated-dependencies:
- dependency-name: "@wdio/cli"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update obsidian-release.yml

Make release as per Obsidian specification

* Bump devtools from 8.6.0 to 8.6.9 (#60)

Bumps [devtools](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/devtools) from 8.6.0 to 8.6.9.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.6.9/packages/devtools)

---
updated-dependencies:
- dependency-name: devtools
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @wdio/local-runner from 8.6.0 to 8.6.9 (#58)

Bumps [@wdio/local-runner](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-local-runner) from 8.6.0 to 8.6.9.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.6.9/packages/wdio-local-runner)

---
updated-dependencies:
- dependency-name: "@wdio/local-runner"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @wdio/cli from 8.6.0 to 8.6.9 (#59)

Bumps [@wdio/cli](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-cli) from 8.6.0 to 8.6.9.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.6.9/packages/wdio-cli)

---
updated-dependencies:
- dependency-name: "@wdio/cli"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump peter-evans/create-or-update-comment from 2 to 3 (#68)

Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment) from 2 to 3.
- [Release notes](https://github.com/peter-evans/create-or-update-comment/releases)
- [Commits](peter-evans/create-or-update-comment@v2...v3)

---
updated-dependencies:
- dependency-name: peter-evans/create-or-update-comment
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @wdio/mocha-framework from 8.5.6 to 8.8.0 (#71)

Bumps [@wdio/mocha-framework](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-mocha-framework) from 8.5.6 to 8.8.0.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.8.0/packages/wdio-mocha-framework)

---
updated-dependencies:
- dependency-name: "@wdio/mocha-framework"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump wdio-electron-service from 4.0.0 to 4.0.2 (#61)

Bumps [wdio-electron-service](https://github.com/webdriverio-community/wdio-electron-service) from 4.0.0 to 4.0.2.
- [Release notes](https://github.com/webdriverio-community/wdio-electron-service/releases)
- [Commits](webdriverio-community/wdio-electron-service@4.0.0...4.0.2)

---
updated-dependencies:
- dependency-name: wdio-electron-service
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update dependabot.yml

* ci: fix by pinning node version (#109)

* Update package-lock.json
* Update test-e2e.yml

* Bump @types/node from 18.15.3 to 20.4.2 (#114)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.15.3 to 20.4.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump semver from 5.7.1 to 5.7.2 (#113)

Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @wdio/spec-reporter from 8.4.0 to 8.12.2 (#112)

Bumps [@wdio/spec-reporter](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-spec-reporter) from 8.4.0 to 8.12.2.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.12.2/packages/wdio-spec-reporter)

---
updated-dependencies:
- dependency-name: "@wdio/spec-reporter"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @wdio/junit-reporter from 8.4.0 to 8.12.2 (#110)

Bumps [@wdio/junit-reporter](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-junit-reporter) from 8.4.0 to 8.12.2.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.12.2/packages/wdio-junit-reporter)

---
updated-dependencies:
- dependency-name: "@wdio/junit-reporter"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump typescript from 4.9.5 to 5.1.6 (#108)

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.9.5 to 5.1.6.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](https://github.com/Microsoft/TypeScript/commits)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump wdio-electron-service from 4.1.0 to 4.3.0 (#120)

Bumps [wdio-electron-service](https://github.com/webdriverio-community/wdio-electron-service) from 4.1.0 to 4.3.0.
- [Release notes](https://github.com/webdriverio-community/wdio-electron-service/releases)
- [Commits](webdriverio-community/wdio-electron-service@4.1.0...4.3.0)

---
updated-dependencies:
- dependency-name: wdio-electron-service
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @wdio/mocha-framework from 8.11.0 to 8.12.1 (#119)

Bumps [@wdio/mocha-framework](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-mocha-framework) from 8.11.0 to 8.12.1.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.12.1/packages/wdio-mocha-framework)

---
updated-dependencies:
- dependency-name: "@wdio/mocha-framework"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump devtools from 8.11.3 to 8.12.1 (#118)

Bumps [devtools](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/devtools) from 8.11.3 to 8.12.1.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.12.1/packages/devtools)

---
updated-dependencies:
- dependency-name: devtools
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump tslib from 2.6.0 to 2.6.1 (#117)

Bumps [tslib](https://github.com/Microsoft/tslib) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/Microsoft/tslib/releases)
- [Commits](microsoft/tslib@2.6.0...v2.6.1)

---
updated-dependencies:
- dependency-name: tslib
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: fix by installing latest obsidian dep (#122)

* ci: fix ci by tagging obsidian to latest
* Update build.yml
* Update other worflows

* Bump devtools from 8.12.1 to 8.13.13 (#121)

Bumps [devtools](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/devtools) from 8.12.1 to 8.13.13.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.13.13/packages/devtools)

---
updated-dependencies:
- dependency-name: devtools
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: apply previous build workflow fix to e2e workflow (#155)

* feat: Add new option to set custom scan directory (#154)

* Add custom scan dir

* Update test suites data.json with new option

* Account for new setting

* Fix undefined variable

* Replace spaces with tabs in changed files

Seems like source code uses tabs (for most part), so replacing
spaces with tabs in files that I've changed for the PR

* Add e2e tests

* Update filename to fix spec requirement

* Add subdir to scan and fix headings in md files

* Update readme with new feature description

* fix tests

---------

Co-authored-by: Harsha Raghu <narnindi.raghu@gmail.com>

* Bump @wdio/mocha-framework from 8.12.1 to 8.16.17 (#162)

Bumps [@wdio/mocha-framework](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-mocha-framework) from 8.12.1 to 8.16.17.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.16.17/packages/wdio-mocha-framework)

---
updated-dependencies:
- dependency-name: "@wdio/mocha-framework"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @types/node from 20.4.2 to 20.8.2 (#161)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.4.2 to 20.8.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump typescript from 5.1.6 to 5.2.2 (#159)

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.1.6 to 5.2.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v5.1.6...v5.2.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump wdio-wait-for from 3.0.5 to 3.0.7 (#148)

Bumps [wdio-wait-for](https://github.com/webdriverio/wdio-wait-for) from 3.0.5 to 3.0.7.
- [Release notes](https://github.com/webdriverio/wdio-wait-for/releases)
- [Commits](webdriverio/wdio-wait-for@3.0.5...3.0.7)

---
updated-dependencies:
- dependency-name: wdio-wait-for
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump tibdex/github-app-token from 1 to 2 (#143)

Bumps [tibdex/github-app-token](https://github.com/tibdex/github-app-token) from 1 to 2.
- [Release notes](https://github.com/tibdex/github-app-token/releases)
- [Commits](tibdex/github-app-token@v1...v2)

---
updated-dependencies:
- dependency-name: tibdex/github-app-token
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/github-script from 6 to 7 (#183)

Bumps [actions/github-script](https://github.com/actions/github-script) from 6 to 7.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v6...v7)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/setup-node from 3 to 4 (#173)

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @rollup/plugin-typescript from 11.1.2 to 11.1.5 (#166)

Bumps [@rollup/plugin-typescript](https://github.com/rollup/plugins/tree/HEAD/packages/typescript) from 11.1.2 to 11.1.5.
- [Changelog](https://github.com/rollup/plugins/blob/master/packages/typescript/CHANGELOG.md)
- [Commits](https://github.com/rollup/plugins/commits/typescript-v11.1.5/packages/typescript)

---
updated-dependencies:
- dependency-name: "@rollup/plugin-typescript"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: Update node and others (#205)

* fix: node-v in test action

* Updates

- Docker update for Ob 1.5.3
- Node update to 18.19 (forced by github actions)
- Chrome update within Obsidian to v114
- Removed uncessary packages
- Reordered Docker layers to have anki and obsidian at last
- now even stderr/stdout is transfered to log files

* fix rollup

* Update test-e2e.yml

* Update test-e2e.yml

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Serhii Prodan <22973227+serpro69@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinsondergaard @Pseudonium