Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in tests? #22

Closed
flip111 opened this issue May 26, 2014 · 2 comments · Fixed by #23
Closed

Typo in tests? #22

flip111 opened this issue May 26, 2014 · 2 comments · Fixed by #23
Assignees
@Ocramius
Labels
bug
Milestone
1.1.0

Comments

@flip111
Copy link

flip111 commented May 26, 2014

I noticed this property called privateProperty is actually declared as protected. https://github.com/Ocramius/GeneratedHydrator/blob/master/tests/GeneratedHydratorTestAsset/BaseClass.php#L42
@Ocramius
Copy link
Owner

Absolute URI:

GeneratedHydrator/tests/GeneratedHydratorTestAsset/BaseClass.php

Line 42 in 42f9f7f

protected $privateProperty = 'privatePropertyDefault';

@Ocramius Ocramius added the bug label May 26, 2014
@Ocramius Ocramius self-assigned this May 26, 2014
@Ocramius Ocramius added this to the 1.1.0 milestone May 26, 2014
Ocramius added a commit that referenced this issue Aug 6, 2014
@Ocramius
#22 - baseclass has a protected property instead of an expected priva…
fe930b1 
…te one
@Ocramius Ocramius mentioned this issue Aug 6, 2014
Merged
Ocramius added a commit that referenced this issue Aug 6, 2014
@Ocramius
Merge pull request #23 from Ocramius/hotfix/#22-baseclass-private-pro…
2f0ea72 
…perty

#22 - baseclass has a protected property instead of an expected private one
@Ocramius
Copy link
Owner

Ocramius commented Aug 6, 2014

Handled in #23

flip111 pushed a commit to flip111/GeneratedHydrator that referenced this issue Nov 23, 2015
@Ocramius @flip111
Ocramius#22 - baseclass has a protected property instead of an expect…
78732c5 
…ed private one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ocramius Ocramius

Labels
bug
Projects
None yet
Milestone
1.1.0
2 participants
@Ocramius @flip111