Bugfix - cannot override final methods ( #187 ) #189

malukenho · 2014-10-21T18:03:23Z

No description provided.

Ocramius · 2014-10-21T20:16:31Z

src/ProxyManager/ProxyGenerator/LazyLoadingValueHolderGenerator.php

-        $classGenerator->addMethodFromGenerator(new MagicSleep($originalClass, $initializer, $valueHolder));
-        $classGenerator->addMethodFromGenerator(new MagicWakeup($originalClass));
+
+        $sleep = $originalClass->getMethod('__sleep');


As discussed on hangouts, this kind of complexity is not sustainable on the long term, and should be abstracted into something like ProxyManager\Generator\ClassGeneratorUtils::addMethodIfNotFinal(ReflectionClass $originalClass, ClassGenerator $classGenerator, MethodGenerator $generatedMethod)

Ocramius · 2014-10-22T00:07:09Z

src/ProxyManager/Generator/Util/ClassGenerator.php

+ * @author Jefersson Nathan <malukenho@phpse.net>
+ * @license MIT
+ */
+class ClassGenerator


Should probably be renamed to ClassGeneratorUtils

- Rename class name `ClassGenerator` to `ClassGeneratorUtils` - Fix docblock on `addMethodIfNotFinal` method - Rename test

Ocramius · 2014-10-22T03:11:13Z

src/ProxyManager/Generator/Util/ClassGeneratorUtils.php

+        GeneratorClass $classGenerator,
+        MethodGenerator $generatedMethod
+    ) {
+        if (! $originalClass->hasMethod($generatedMethod->getName())) {


Cache the call to getName in a variable

- Fix implementation for allow create methods not existents

Ocramius · 2014-10-22T17:50:48Z

Linking #187

Ocramius · 2014-10-22T17:51:14Z

src/ProxyManager/Generator/Util/ClassGeneratorUtils.php

+        $methodName = $generatedMethod->getName();
+
+        if ($originalClass->hasMethod($methodName)
+            and $originalClass->getMethod($methodName)->isFinal()) {


please don't use and: use &&

…ddMethodIfNotFinal()` - Rewrite test

Ocramius · 2014-10-22T22:03:46Z

src/ProxyManager/ProxyGenerator/LazyLoadingGhostGenerator.php

-        $classGenerator->addMethodFromGenerator(new MagicUnset($originalClass, $initializer, $init, $publicProperties));
-        $classGenerator->addMethodFromGenerator(new MagicClone($originalClass, $initializer, $init));
-        $classGenerator->addMethodFromGenerator(new MagicSleep($originalClass, $initializer, $init));
+        ClassGeneratorUtils::addMethodIfNotFinal(


Looking at it again: you can array_map this stuff :-)

…thod generators

…method calls manually

Ocramius · 2014-10-23T00:41:43Z

tests/ProxyManagerTest/Functional/MultipleProxyGenerationTest.php

@@ -102,6 +102,7 @@ public function getTestedClasses()
        $data = array(
            array('ProxyManagerTestAsset\\BaseClass'),
            array('ProxyManagerTestAsset\\ClassWithMagicMethods'),
+            array('ProxyManagerTestAsset\\ClassWithFinalMagicMethods'),


We also need an additional ClassWithFinalMethods

Ocramius · 2014-10-23T00:45:34Z

src/ProxyManager/Generator/Util/ClassGeneratorUtils.php

+     *
+     * @return void
+     */
+    public static function addMethodIfNotFinal(


A test dedicated only to ClassGeneratorUtils is missing

…etition Ocramius#189 - reducing repetition

- Fix return and docBlock

Ocramius · 2014-10-23T21:08:09Z

tests/ProxyManagerTest/Generator/Util/ClassGeneratorUtilsTest.php

+{
+    public function testCantAddAFinalMethod()
+    {
+        $classGenerator = $this->getMock('Zend\\Code\\Generator\\ClassGenerator');


May want to assert $classGenerator->expects($this->never())->method('addMethodFromGenerator');

…ethods Bugfix on inherit private magic methods

Total issues resolved: **17** - [108: Fix windows path length limitations](#108) - [172: Alternate hotfix for #108 - windows path length limitations](#172) - [178: Verify type-safety with `self` and `static` type-hints](#178) - [180: #178 - `self` type safety check](#180) - [181: Documentation should be released on github pages on the `gh-pages` branch.](#181) - [182: Documentation on github pages](#182) - [187: Proxy generation fails if magic methods are marked as final](#187) - [189: Bugfix - cannot override final methods ( #187 )](#189) - [190: [WIP] [EXPERIMENTAL] Codegen should not trigger fatals](#190) - [191: Put link of documentation on README.md and Close #185](#191) - [193: [WIP] Codegen errors](#193) - [194: Code-generation fatal error prevention](#194) - [195: Blogpost about 1.0.0, 2.0.0 and stability frames](#195) - [196: Define maintainance time-frames (stable/oldstable/etc)](#196) - [198: Highlighting the code examples](#198) - [199: Removed unused `ReflectionMethod` import](#199) - [202: #196 - adding document with expected stability time-frames](#202)

malukenho added 2 commits October 21, 2014 14:45

Add teste case for issue Ocramius#187

df89358

Add conditions to generate magic methods

baa3ab0

Ocramius reviewed Oct 21, 2014
View reviewed changes

Implemet solution to not generate magic method if it's final

e4b4bab

Ocramius reviewed Oct 22, 2014
View reviewed changes

Rewrite implementation

61ec8c4

- Rename class name `ClassGenerator` to `ClassGeneratorUtils` - Fix docblock on `addMethodIfNotFinal` method - Rename test

malukenho force-pushed the bugfix/extends-private-magic-methods branch from b4a9410 to 61ec8c4 Compare October 22, 2014 01:07

Fix @cover docBlock

6daac11

Ocramius reviewed Oct 22, 2014
View reviewed changes

malukenho added 2 commits October 22, 2014 10:50

Tests build pass

78ff2d3

- Fix implementation for allow create methods not existents

Fix cs

54560e3

malukenho force-pushed the bugfix/extends-private-magic-methods branch from d38f214 to 54560e3 Compare October 22, 2014 14:17

Ocramius added bug enhancement and removed enhancement labels Oct 22, 2014

Ocramius added this to the 1.0.0 milestone Oct 22, 2014

Ocramius self-assigned this Oct 22, 2014

Ocramius reviewed Oct 22, 2014
View reviewed changes

malukenho added 2 commits October 22, 2014 16:16

Replace and by && operator

f9a22a9

Use a class for assert test instead of PDO

49af12b

malukenho force-pushed the bugfix/extends-private-magic-methods branch from 8f65492 to 49af12b Compare October 22, 2014 19:48

Replace call of addMethodFromGenerator() by `ClassGeneratorUtils::a…

b726dbe

…ddMethodIfNotFinal()` - Rewrite test

Ocramius reviewed Oct 22, 2014
View reviewed changes

Ocramius#189 - ClassGeneratorUtils should work also with generic me…

7b7abbc

…thod generators

Ocramius added 7 commits October 23, 2014 02:00

Ocramius#189 - iterating over generated methods instead of repeating …

f9d9b9d

…method calls manually

Ocramius#189 - removing unused variable

4948140

Ocramius#189 - optimized imports

93b2d04

Ocramius#189 - iterating over generated methods instead of repeating …

5d9b252

…method calls manually

Ocramius#189 - iterating over generated methods instead of repeating …

fc9e160

…method calls manually

Ocramius#189 - iterating over generated methods instead of repeating …

c245896

…method calls manually

Ocramius#189 - iterating over generated methods instead of repeating …

204b7b8

…method calls manually

Ocramius reviewed Oct 23, 2014
View reviewed changes

Ocramius mentioned this pull request Oct 23, 2014

#189 - reducing repetition malukenho/ProxyManager#1

Merged

Ocramius reviewed Oct 23, 2014
View reviewed changes

Merge pull request #1 from Ocramius/cleanup/Ocramius#189-reducing-rep…

7b6a920

…etition Ocramius#189 - reducing repetition

Ocramius mentioned this pull request Oct 23, 2014

[WIP] [EXPERIMENTAL] Codegen should not trigger fatals #190

Merged

malukenho added 3 commits October 23, 2014 16:09

Add test to a class with another final methods

458b141

Import PHPUnit_Framework_TestCase namespace on the test classe

c5e8188

Write tests for ClassGeneratorUtils

470e253

- Fix return and docBlock

Ocramius reviewed Oct 23, 2014
View reviewed changes

malukenho added 3 commits October 23, 2014 18:25

Add a __construct() method to tests on ClassWithFinalMagicMethods

140243d

Don't use __construct() method to this class assert

cd53b44

Modify way of make test and create a case of test pass

05fd973

Ocramius added a commit that referenced this pull request Oct 23, 2014

Merge pull request #189 from malukenho/bugfix/extends-private-magic-m…

dd6153d

…ethods Bugfix on inherit private magic methods

Ocramius merged commit dd6153d into Ocramius:master Oct 23, 2014

Ocramius mentioned this pull request Oct 23, 2014

Proxy generation fails if magic methods are marked as final. #187

Closed

Ocramius changed the title ~~Bugfix on inherit private magic methods~~ Bugfix - cannot override final methods ( #187 ) Oct 24, 2014

Ocramius mentioned this pull request Jul 6, 2019

ValueHolder proxy for class with accessing to private property within final method #472

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix - cannot override final methods ( #187 ) #189

Bugfix - cannot override final methods ( #187 ) #189

malukenho commented Oct 21, 2014

Ocramius Oct 21, 2014

Ocramius Oct 22, 2014

Ocramius Oct 22, 2014

Ocramius Oct 22, 2014

Ocramius commented Oct 22, 2014

Ocramius Oct 22, 2014

Ocramius Oct 22, 2014

Ocramius Oct 23, 2014

Ocramius Oct 23, 2014

Ocramius Oct 23, 2014

Bugfix - cannot override final methods ( #187 ) #189

Bugfix - cannot override final methods ( #187 ) #189

Conversation

malukenho commented Oct 21, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ocramius commented Oct 22, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment