Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure release note is updated #1050

Merged
merged 3 commits into from
Oct 3, 2020
Merged

Ensure release note is updated #1050

merged 3 commits into from
Oct 3, 2020

Conversation

stefanbuck
Copy link
Member

@stefanbuck stefanbuck commented Oct 2, 2020 •
edited by pull-request-badge bot
Loading

Pull Request Badge

This change ensures that a release description is added before performing a release using npm version <patch|minor|major>

xt0rted
xt0rted approved these changes Oct 3, 2020
View reviewed changes
Copy link
Member

@xt0rted xt0rted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script comment looks like it might be wrong, otherwise looks good to me.

scripts/version.sh Outdated Show resolved Hide resolved
@stefanbuck stefanbuck merged commit 2a6a672 into main Oct 3, 2020
@stefanbuck stefanbuck deleted the release-note branch October 3, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xt0rted xt0rted xt0rted approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanbuck @xt0rted