-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project sdk support for .net #787
Conversation
CI stucks , most likely caused by the force push. Maybe best to recreate the commit from scratch |
It wasn't running before the force push. The workflow might need to be adjusted to something like this: on:
push:
branches:
- master
pull_request: That's how I set it up for GitHub Dark so it'd handle pushes to master, PRs from local branches, and PRs from forks. Running on |
A few minutes ago I remove the |
done |
@stefanbuck I forgot the sdk value could contain multiple values like this |
That might be tricky. I need to look into this myself before I can say anything useful 😉 |
I looked into it and it's rather complicated to make this work. The current OctoLinker architecture is based on the assumption that each RegExp returns just one result. Changing this requires some larger rewrites down the line. Most likely not worth the effort. |
From what I know having multiple values for this isn't common. I've never seen it done in a project outside of my own so I doubt many people would hit this. |
Checklist:
This builds on #785 so the
Sdk
attribute is also handled now.