Enabling Nullable Reference Types #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tream Result<> things to work
uglybugger
reviewed
Jun 25, 2020
uglybugger
approved these changes
Jun 25, 2020
# Conflicts: # source/Octopus.Data/Model/SensitiveString.cs # source/Octopus.Data/Model/User/IdentityClaim.cs # source/Octopus.Data/Resources/Attributes/PropertyApplicabilityAttribute.cs # source/Octopus.Data/Resources/Resource.cs # source/Octopus.Data/Resources/Users/IdentityClaimResource.cs # source/Octopus.Data/Resources/Users/IdentityResource.cs # source/Octopus.Data/Storage/User/ApiKeyDescriptor.cs # source/Tests/IdentityResourceTests.cs # source/Tests/IdentityTests.cs
uglybugger
approved these changes
Jun 30, 2020
…rics based value. Without this the default value being applied the null checks get upset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involved a number of changes to classes in this library. Most were changes to the ctors to force required things, where we'd been relying on object initializers and everyone setting the properties correctly.
Result<T>has also been moved to here, from the server codebase. It is used in cases where we want to return an object that explains reasons, rather than just a null.