Reviewing naming of Variable Sets #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are quite a few images in here with a missing opening Should be: Sending a commit to fix this and resolve some spelling issues. |
|
I can sort out this merge for you tomorrow. |
|
Ah it was the image tags! I was so confused by the spell check errors. Thank you. I'm still reviewing some of these changes later today, but this is in a much nicer position now, thank you. |
…ew this more carefully later on the backend
|
Thanks @steve-fenton-octopus. This one is now ready for review please 🙏 |
steve-fenton-octopus
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for Vertical Navigation's release next week, we've been reviewing docs and discovered various combinations of the wording around "Variable Sets".
This PR reviews the various wording and standardises where appropriate, based on both the current UI and the new UI coming soon. We no longer refer to "Variable Sets" as "Library Variable Sets" or "Library Sets". They are just Variable Sets.