Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Publish v3 #381

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Implement Publish v3 #381

wants to merge 1 commit into from

Conversation

ktprograms
Copy link
Collaborator

  • Re-run notify if Tus returns error "upload is still in process".
  • Poll status every 10 seconds (12 times) while response is 202.
  • Use horizontal progress bar with determinate progress while Tus is uploading. This lets there be a meaningful indicator while uploading a large file.

The "Check Status" button (used when the retry count has been exceeded polling status) is only shown in the Publish Form, since it won't navigate away until the publish is successful.

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

  • Feature

Fixes

Fix: #365

- Re-run notify if Tus returns error "upload is still in process".
- Poll status every 10 seconds (12 times) while response is 202.
- Use horizontal progress bar with determinate progress while Tus is
  uploading. This lets there be a meaningful indicator while uploading a
  large file.

The "Check Status" button (used when the retry count has been exceeded
polling status) is only shown in the Publish Form, since it won't
navigate away until the publish is successful.

Fix: #365
@ktprograms ktprograms marked this pull request as draft November 2, 2022 08:52
Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@ktprograms
Copy link
Collaborator Author

ktprograms commented Nov 3, 2022

FYI This isn't ready yet. Still needs a global "pending" list so LogPublishTask can be run later after manually checking status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move v2 to v3 publish API
2 participants