Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livestream chat: use commentron, respect default channel #383

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ktprograms
Copy link
Collaborator

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature

Fixes

Issue Number: N/A

What is the current behavior?

Unable to send chat messages on livestreams.

What is the new behavior?

Fixed sending chat messages on livestreams by using commentron create.
Also respect default channel when commenting.

@ktprograms ktprograms marked this pull request as draft November 1, 2022 08:19
Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@akinwale
Copy link
Contributor

akinwale commented Nov 3, 2022

@ktprograms Let me know when this is ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants