Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/player #116

Closed
wants to merge 24 commits into from
Closed

Improvement/player #116

wants to merge 24 commits into from

Conversation

anbsky
Copy link
Collaborator

@anbsky anbsky commented Nov 20, 2019

Streaming directly from reflector service implemented.
Most improvements are in app/player/player.go which has been completely rewritten.

Copy link
Member

@nikooo777 nikooo777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
sorry for the delayed review!

app/player/player.go Outdated Show resolved Hide resolved
internal/monitor/monitor.go Outdated Show resolved Hide resolved
internal/monitor/monitor.go Outdated Show resolved Hide resolved
internal/reflection/manager.go Outdated Show resolved Hide resolved
server/server.go Show resolved Hide resolved
go.mod Show resolved Hide resolved
@lbry-bot lbry-bot assigned anbsky and unassigned tiger5226 and anbsky Nov 27, 2019
@anbsky anbsky closed this Nov 28, 2019
@anbsky
Copy link
Collaborator Author

anbsky commented Nov 28, 2019

This needs further improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants