Feature/reflection #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyoshenka
reviewed
Sep 17, 2019
| // Abort resets the upload schedule and cancels blob upload | ||
| // after the currently uploading blob is finished. | ||
| func (r *Manager) Abort() { | ||
| r.abortTimer <- true |
There was a problem hiding this comment.
have you looked at https://github.com/lbryio/lbry.go/tree/master/extras/stop ?
There was a problem hiding this comment.
I have, but cannot figure out how it would be beneficial to use here instead of two plain channels. Might be a different story if uploads need to be parallelized later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to use public API. I decided that to make any optimizations like parallel uploads at this point would be premature.