Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollup contracts #148

Merged
merged 34 commits into from
Feb 15, 2022
Merged

Add rollup contracts #148

merged 34 commits into from
Feb 15, 2022

Conversation

PlasmaPower
Copy link
Collaborator

@PlasmaPower PlasmaPower commented Jan 13, 2022

See #160 for a diff against the classic rollup v2 contracts which this is based on

Fixes #143

@PlasmaPower PlasmaPower changed the base branch from master to l1-blocknumber-blockhash January 14, 2022 17:41
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #148 (6ae6d55) into master (109b1f2) will decrease coverage by 0.04%.
The diff coverage is 57.97%.

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   62.41%   62.36%   -0.05%     
==========================================
  Files          93       93              
  Lines       14401    14540     +139     
==========================================
+ Hits         8988     9068      +80     
- Misses       4536     4575      +39     
- Partials      877      897      +20     

@PlasmaPower PlasmaPower marked this pull request as ready for review January 14, 2022 17:44
Base automatically changed from l1-blocknumber-blockhash to master January 14, 2022 21:04
PlasmaPower and others added 11 commits February 5, 2022 21:35
* Refactor rollup dispatch to not include domain logic

* Fix owner assignment during init

* Refactor rollup contracts to favour calldata than memory in structs

* Refactor rollup lib to use calldata over memory

* Remove todo

* Add cloneable super class to proxy contracts

* Add unit test and fix storage layout for proxy
Go already covers this, and it was failing in CI
Copy link
Contributor

@hkalodner hkalodner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkalodner hkalodner merged commit b2f3f94 into master Feb 15, 2022
rachel-bousfield added a commit that referenced this pull request Apr 19, 2024
Ferret-san pushed a commit to celestiaorg/nitro that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port rollup contract from old stack
5 participants