-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rollup contracts #148
Merged
Merged
Add rollup contracts #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
- Coverage 62.41% 62.36% -0.05%
==========================================
Files 93 93
Lines 14401 14540 +139
==========================================
+ Hits 8988 9068 +80
- Misses 4536 4575 +39
- Partials 877 897 +20 |
This was referenced Jan 29, 2022
5 tasks
* Refactor rollup dispatch to not include domain logic * Fix owner assignment during init * Refactor rollup contracts to favour calldata than memory in structs * Refactor rollup lib to use calldata over memory * Remove todo * Add cloneable super class to proxy contracts * Add unit test and fix storage layout for proxy
Go already covers this, and it was failing in CI
yahgwai
force-pushed
the
rollup-contracts
branch
from
February 15, 2022 15:45
cbd2115
to
8e7e4bf
Compare
hkalodner
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ferret-san
pushed a commit
to celestiaorg/nitro
that referenced
this pull request
Aug 27, 2024
Remove postgres in espresso e2e test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #160 for a diff against the classic rollup v2 contracts which this is based on
Fixes #143