Make the data poster nonce query resilient #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
amsanghi
previously approved these changes
May 16, 2023
|
I've pushed up a fix that will error if the queue is ephemeral and we fail to get the latest finalized nonce, as we might be affected by a reorg in that case |
amsanghi
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the batch poster a lot more resilient to L1 node issues, particularly if the state of the latest finalized block is not available. In that case, it'll continue normal operation without pruning the queue until the finalized state is available again. On startup, it'll continue adding to the queue as usual even if the finalized state isn't available. If the queue is empty, it'll query the latest block instead, which is safe because the queue being empty means there aren't any unconfirmed transactions floating around that might change during a reorg.