Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix CI #165

Merged
merged 6 commits into from
Jan 22, 2022
Merged

Try to fix CI #165

merged 6 commits into from
Jan 22, 2022

Conversation

rachel-bousfield
Copy link
Contributor

@rachel-bousfield rachel-bousfield commented Jan 21, 2022

This PR attempts to fix CI by

  • Adding a gas-estimation margin of 20% to the default transaction opts
  • Making SendWaitTestTransactions block on all txes rather than just the last

The gas margin portion requires the following Geth PR

@rachel-bousfield rachel-bousfield marked this pull request as draft January 21, 2022 03:45
@rachel-bousfield rachel-bousfield changed the title Try to fix CI via gas margin Try to fix CI Jan 21, 2022
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #165 (63dfd6a) into master (6a3ef56) will increase coverage by 53.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #165       +/-   ##
===========================================
+ Coverage        0   53.02%   +53.02%     
===========================================
  Files           0       75       +75     
  Lines           0     8807     +8807     
===========================================
+ Hits            0     4670     +4670     
- Misses          0     3388     +3388     
- Partials        0      749      +749     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants