Invert next-slot-state-cache flag (#8830)

* Invert `next-slot-state-cache`

* Go fmt

Co-authored-by: Nishant Das <nishdas93@gmail.com>

Author: terencechain

shared/featureconfig/config.go

@@ -178,9 +178,10 @@ func ConfigureBeaconChain(ctx *cli.Context) {
 		log.WithField(disableBroadcastSlashingFlag.Name, disableBroadcastSlashingFlag.Usage).Warn(enabledFeatureFlag)
 		cfg.DisableBroadcastSlashings = true
 	}
-	if ctx.Bool(enableNextSlotStateCache.Name) {
-		log.WithField(enableNextSlotStateCache.Name, enableNextSlotStateCache.Usage).Warn(enabledFeatureFlag)
-		cfg.EnableNextSlotStateCache = true
+	cfg.EnableNextSlotStateCache = true
+	if ctx.Bool(disableNextSlotStateCache.Name) {
+		log.WithField(disableNextSlotStateCache.Name, disableNextSlotStateCache.Usage).Warn(enabledFeatureFlag)
+		cfg.EnableNextSlotStateCache = false
 	}
 	if ctx.Bool(updateHeadTimely.Name) {
 		log.WithField(updateHeadTimely.Name, updateHeadTimely.Usage).Warn(enabledFeatureFlag)

shared/featureconfig/deprecated_flags.go

@@ -37,6 +37,11 @@ var (
 		Usage:  deprecatedUsage,
 		Hidden: true,
 	}
+	deprecatedEnableNextSlotCache = &cli.BoolFlag{
+		Name:   "enable-next-slot-state-cache",
+		Usage:  deprecatedUsage,
+		Hidden: true,
+	}
 	deprecatedProposerAttsSelectionUsingMaxCover = &cli.BoolFlag{
 		Name:   "proposer-atts-selection-using-max-cover",
 		Usage:  deprecatedUsage,
@@ -51,5 +56,6 @@ var deprecatedFlags = []cli.Flag{
 	deprecatedDisablePruningDepositProofs,
 	deprecatedDisableEth1DataMajorityVote,
 	deprecatedDisableBlst,
+	deprecatedEnableNextSlotCache,
 	deprecatedProposerAttsSelectionUsingMaxCover,
 }

shared/featureconfig/flags.go

@@ -102,9 +102,9 @@ var (
 		Name:  "attest-timely",
 		Usage: "Fixes validator can attest timely after current block processes. See #8185 for more details",
 	}
-	enableNextSlotStateCache = &cli.BoolFlag{
-		Name:  "enable-next-slot-state-cache",
-		Usage: "Improves attesting and proposing efficiency by caching the next slot state at the end of the current slot",
+	disableNextSlotStateCache = &cli.BoolFlag{
+		Name:  "disable-next-slot-state-cache",
+		Usage: "Disable caching of the next slot state at the end of the current slot",
 	}
 	updateHeadTimely = &cli.BoolFlag{
 		Name:  "update-head-timely",
@@ -123,7 +123,6 @@ var (
 // devModeFlags holds list of flags that are set when development mode is on.
 var devModeFlags = []cli.Flag{
 	enableLargerGossipHistory,
-	enableNextSlotStateCache,
 	forceOptMaxCoverAggregationStategy,
 	updateHeadTimely,
 }
@@ -170,7 +169,7 @@ var BeaconChainFlags = append(deprecatedFlags, []cli.Flag{
 	enableLargerGossipHistory,
 	checkPtInfoCache,
 	disableBroadcastSlashingFlag,
-	enableNextSlotStateCache,
+	disableNextSlotStateCache,
 	forceOptMaxCoverAggregationStategy,
 	updateHeadTimely,
 	disableProposerAttsSelectionUsingMaxCover,