Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated msg unfurling with domain URL #1276

Merged
merged 4 commits into from
May 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,7 @@
"type": "link",
"value": {
"domains": [
"{{domain-name}}",
"ngrok-free.app"
"{{domain-name}}"
]
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/msgext-link-unfurling-meeting/csharp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ This sample illustrates a common scenario where a user shares a link to a resour

![SignIn](Docs/SignIn.png)

**Create link - https://<your_tunnel_domain>/api/messages/dashboard1:**
**Create link - https://<your_tunnel_domain>/dashboard1:**

![MsgextLinkMeeting](Docs/MsgextLinkMeeting.png)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"type": "link",
"value": {
"domains": [
"*.botframework.com"
"teamstestdomain.com/teams/csharp"
]
}
}
Expand Down
Binary file modified samples/msgext-link-unfurling/csharp/Images/Add-App.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified samples/msgext-link-unfurling/csharp/Images/Link-Unfurling.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion samples/msgext-link-unfurling/csharp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ the Teams service needs to call into the bot.

> Note the Teams `manifest.json` for this sample also includes a Search Query. This Messaging Extension is only introduced in order to enable installation, because there is no mechanism for installing a link unfurling feature in isolation.

If you copy and paste a link from https://www.BotFramework.com into the compose message area the link will unfurl.
If you copy and paste the link `https://teamstestdomain.com/teams/csharp`, it wil unfurl inside compose area.

- Note : To enable link unfurling for your domain, add your domain to the manifest.json file under message handlers.
![Link-Unfurling ](Images/Link-Unfurling.png)

## Outlook on the web
Expand Down
Binary file modified samples/msgext-link-unfurling/nodejs/Images/InstallApp.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified samples/msgext-link-unfurling/nodejs/Images/Link-Unfurling.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified samples/msgext-link-unfurling/nodejs/Images/LinkUnfurling.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 4 additions & 2 deletions samples/msgext-link-unfurling/nodejs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ urlFragment: officedev-microsoft-teams-samples-msgext-link-unfurling

# Teams Link Unfurl Bot Node.js

If you copy and paste a link from `https://www.botframework.com` or your tunnel base url, it wil unfurl inside compose area.
If you copy and paste the link `https://teamstestdomain.com/teams/test` or your tunnel base url, it wil unfurl inside compose area.

- Note : To enable link unfurling for your domain, add your domain to the manifest.json file under message handlers.

## Included Features
* Bots
Expand Down Expand Up @@ -115,7 +117,7 @@ In Azure portal, create a [Azure Bot resource](https://docs.microsoft.com/azure/

![InstallApp ](Images/InstallApp.png)

If you copy and paste a link from https://www.BotFramework.com into the compose message area the link will unfurl.
If you copy and paste a link from https://teamstestdomain.com/teams/test into the compose message area the link will unfurl.
![Link-Unfurling ](Images/Link-Unfurling.png)

![Link-Unfurling ](Images/Link-Unfurling1.png)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"value": {
"domains": [
"${{BOT_DOMAIN}}",
"*.botframework.com",
"teamstestdomain.com/teams/test",
"{{domain-name}}"
]
}
Expand Down
4 changes: 2 additions & 2 deletions samples/tab-stage-view/csharp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ Please find below demo manifest which is deployed on Microsoft Azure and you can

![LinkUnfurlingStageView](TabInStageView/Images/LinkUnfurlingStageView.png)

**Opening stage view from unfurling link. If you copy and paste a link from https://www.BotFramework.com into the compose message area the link will unfurl.**
**Opening stage view from unfurling link. If you copy and paste a link from https://tabstageview.com/card into the compose message area the link will unfurl.**

![LinkUnfurlingText](TabInStageView/Images/LinkUnfurlingText.png)

Expand Down Expand Up @@ -180,7 +180,7 @@ Please find below demo manifest which is deployed on Microsoft Azure and you can

![OpenAppIcon](TabInStageView/Images/OpenAppIcon.png)

**Opening the stage view from unfurling link. If you copy and paste a link from https://www.BotFramework.com into the compose message area the link will unfurl.**
**Opening the stage view from unfurling link. If you copy and paste a link from https://tabstageview.com/card into the compose message area the link will unfurl.**

![Outlook Unfurling](TabInStageView/Images/OutlookUnfurling.png)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"type": "link",
"value": {
"domains": [
"*.botframework.com",
"tabstageview.com/card",
"{{domain-name}}"
]
}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified samples/tab-stage-view/nodejs/Images/LinkUnfurlingText.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified samples/tab-stage-view/nodejs/Images/TabStageView.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions samples/tab-stage-view/nodejs/Readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ Also update `BaseUrl` according to your code runtime environment.

![LinkUnfurlingStageView](Images/LinkUnfurlingStageView.png)

**Opening stage view from unfurling link. If you copy and paste a link from https://www.BotFramework.com into the compose message area, the link will unfurl.**
**Opening stage view from unfurling link. If you copy and paste a link from https://tabstageview.com/card into the compose message area, the link will unfurl.**

![LinkUnfurlingText](Images/LinkUnfurlingText.png)

Expand Down Expand Up @@ -221,7 +221,7 @@ Also update `BaseUrl` according to your code runtime environment.

![OpenAppIcon](Images/OpenAppIcon.png)

**Opening stage view from unfurling link. If you copy and paste a link from https://www.BotFramework.com into the compose message area the link will unfurl.**
**Opening stage view from unfurling link. If you copy and paste a link from https://tabstageview.com/card into the compose message area the link will unfurl.**

![Outlook Unfurling](Images/OutlookUnfurling.png)

Expand Down
2 changes: 1 addition & 1 deletion samples/tab-stage-view/nodejs/appManifest/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"type": "link",
"value": {
"domains": [
"*.botframework.com",
"tabstageview.com/card",
"${{BOT_DOMAIN}}"
]
}
Expand Down