This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
added pkce and fixed some bugs with authorization code grant #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
schmitch
force-pushed
the
pkce-authorization-code-grant
branch
from
cada870
to
bf26eb8
Compare
office-js had a major flaw for authorization code grant types, it didn't send the correct payload for a token exchange currently this fixes it by sending a correct application/x-www-form-urlencoded request and also made it possible to configure PKCE by utilizing CryptoJS
schmitch
force-pushed
the
pkce-authorization-code-grant
branch
from
bf26eb8
to
3e34857
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
office-js had a major flaw for authorization code grant types,
it didn't send the correct payload for a token exchange
currently this fixes it by sending a correct application/x-www-form-urlencoded
request and also made it possible to configure PKCE by utilizing CryptoJS
Edit: after that I will probably take a look at refresh tokens, and might implement them as well. So that users won't need to re-login like they need in a setup with implicit flow