Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Modified regex in extractParams to ignore leading frontslash #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Seebiscuit
Copy link

This PR relates to #90. Please, refer to that issue for the motivation.

As explained in that PR the regex used in src/authentication/authenticator.ts:125 was modified from

/([^&=]+)=([^&]*)/g

to

/[\/]?([^&=]+)=([^&]*)/g

to ignore front-slashes. Also, that removes to perform the following check:

      // Fixes bugs when the state parameters contains a / before them
      if (matchParts[1] === '/state') {
        matchParts[1] = matchParts[1].replace('/', '');
      }

So those lines were removed.

PS, I think Prettier buggered your current formatting. I'm very sorry. I didn't want to do a global replace in case I messed something else up. Please, let me know what formatter you're using and I'l try to clean that up.

@msftclas
Copy link

msftclas commented May 17, 2018

CLA assistant check
All CLA requirements met.

@Seebiscuit
Copy link
Author

I have tested in a current project.

@WrathOfZombies
Copy link
Contributor

@casieber Can you take a look at this?

@Seebiscuit
Copy link
Author

@WrathOfZombies, @casieber any chance this can get merged? I know everyone's busy, but I'd be happy to help any way I can.

@Seebiscuit
Copy link
Author

Hey, @WrathOfZombies, @Zlatkovsky , or any other admin, I can no longer maintain this PR. Feel free to assign someone else to it or close it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants