This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
Modified regex in extractParams to ignore leading frontslash #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to #90. Please, refer to that issue for the motivation.
As explained in that PR the regex used in
src/authentication/authenticator.ts:125
was modified from/([^&=]+)=([^&]*)/g
to
/[\/]?([^&=]+)=([^&]*)/g
to ignore front-slashes. Also, that removes to perform the following check:
So those lines were removed.
PS, I think Prettier buggered your current formatting. I'm very sorry. I didn't want to do a global replace in case I messed something else up. Please, let me know what formatter you're using and I'l try to clean that up.