This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
feat: Add new m365 icon, add brand icons page to docs, and refactor code #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahgodbolt
reviewed
Dec 7, 2022
Jahnp
previously approved these changes
Dec 8, 2022
src/sass/_BrandIcon.scss
Outdated
| @@ -22,87 +23,87 @@ | |||
| // a future release. Until then, they are mapped to 'one' and 'xlsx'. | |||
|
|
|||
| .ms-BrandIcon--onepkg.ms-BrandIcon--icon16 { | |||
| background-image: url(https://spoprod-a.akamaihd.net/files/fabric/assets/item-types-fluent/16/one.png); | |||
| background-image: url('#{$ms-cdn-path}/item-types-fluent/16/one.png'); | |||
There was a problem hiding this comment.
As long as you're changing these, you should be able to replace item-types-fluent with item-types. That's the more up to date and maintained assets directory.
There was a problem hiding this comment.
will make the change!
micahgodbolt
approved these changes
Dec 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
Fixes microsoft/fluentui#25928