Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pagination for blacklisted words and websites #118

Merged
merged 1 commit into from
May 27, 2016

Conversation

ankit-m
Copy link
Contributor

@ankit-m ankit-m commented May 26, 2016

pagination

It limits to 4 entries per page and automatically creates new pages as per the entries.

@ceilican ceilican merged commit 9a1bbcf into OiWorld:master May 27, 2016
@ceilican
Copy link
Contributor

Thanks!

@ceilican
Copy link
Contributor

And what happens when the number of pages is so large that it doesn't fit in the available horizontal space?

@ankit-m
Copy link
Contributor Author

ankit-m commented May 27, 2016

@ceilican I am working on that edge case. I will mostly add a next button. and limit the number of pages shown.

@rohankatyal29
Copy link
Contributor

Can we use a fixed sized window with scroll in it? This style breaks ui
with every new addition. The dimensions of the box should remain static

On Thursday 26 May 2016, Ankit Muchhala notifications@github.com wrote:

[image: pagination]
https://cloud.githubusercontent.com/assets/9019878/15584110/b621393e-2396-11e6-88ea-52699e40f60c.png

It limits to 4 entries per page and automatically creates new pages as per

the entries.

You can view, comment on, or merge this pull request online at:

#118
Commit Summary

  • pagination for blacklisted words and websites

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#118

Regards,
Rohan Katyal

Please ignore the typos and brevity, email sent using a small form factor
device

@ankit-m
Copy link
Contributor Author

ankit-m commented May 27, 2016

@rohankatyal29 I am not sure about scrolling. But the dimensions of the box could be made static. That will solve the problem of box resizing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants