Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes thread safety in CustomObjectDetection not working #418

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixes thread safety in CustomObjectDetection not working #418

wants to merge 3 commits into from

Commits on Nov 24, 2019

  1. fixes thread safety in CustomObjectDetection not working 

    This change removes the thread_safe flag because it opts to always make object detection thread safe through the use of tf Sessions. It makes sense to remove the thread_safe flag since we need to setup the Session & Graph beforehand and don't want to introduce a bunch of extra thread_safe checks for no good reason.

More details on the fix here: tensorflow/tensorflow#28287 (comment)
    @GusBricker
    GusBricker committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    c83553b View commit details
    Browse the repository at this point in the history

  2. lock down tensorflow & keras version 

    This is to ensure we get compatible versions of the two libraries. At the time of writing, if we let keras install 2.3.1 then we also get a bug which breaks threaded detection. See here for more details: keras-team/keras#13353
    @GusBricker
    GusBricker committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    f42a1b2 View commit details
    Browse the repository at this point in the history

  3. updates requirements to remove typo 

    fixes keras version typo.
    @GusBricker
    GusBricker committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    a657e02 View commit details
    Browse the repository at this point in the history