Make enhanced cljs completion optional #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 24, 2020 16:18
Only send :enhanced-cljs-completion? when `conjure#client#clojure#nrepl#completion#cljs#use_suitable` is true
hpointu
changed the title
Olical
approved these changes
Jul 24, 2020
|
I think when this is fixed and okay in the future I'll flip the default to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems a recent version of clj-suitable broke cljs completion,
see clojure-emacs/clj-suitable#15 for more details
Having clj-suitable optional (from config) is an ok workaround, until this is fixed.
This PR introduces a conf :
g:conjure#client#clojure#nrepl#completion#cljs#use_suitable, to control the use of clj-suitable.This conf value is also initialized to
falseby default, because as it stands, putting it to true wouldn't work.